Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487157

Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER

Show all headers | View raw

Hi Philipp,


2016-09-20 16:30 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Hi Masahiro,
>
> Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada:
>> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been
>> merged.  Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Philipp,
>>
>> IIRC, you mentioned that you were planning to consolidate the double
>> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER.
>>
>> I have not seen it in the ML, so I am sending this.
>>
>> Please let me know if you have some updates.
>
> I had started to doodle a bit, see
>
>     git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig
>
> but I haven't found time for cleanup and testing.


OK, I will merge this patch for now.



BTW, I did not understand some of your commits under way.


commit 7fe911f9c83737449565db03bebf953d3d94bbbf
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date:   Tue Aug 9 11:18:51 2016 +0200

    dmaengine: sunx6i: do not depend on reset controller framework

    The reset controller framework provides inline function stubs if
    disabled.

    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>





As far as I see from drivers/dma/sun6i-dma.c,
the reset control is mandatory for this driver.

Why are you removing the dependency?


Don't you care if it works on run-time
as long as it can build?




-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-20 06:50 +0200
  Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 09:40 +0200
  Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 09:40 +0200
    Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-20 10:50 +0200
      Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 12:50 +0200

csiph-web