Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487149 > unrolled thread

[PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2016-09-20 10:40 +0200
Last post2016-09-21 20:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-20 10:40 +0200
    Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by  of_iomap James Liao <jamesjj.liao@mediatek.com> - 2016-09-21 05:40 +0200
    Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by  of_iomap Stephen Boyd <sboyd@codeaurora.org> - 2016-09-21 20:50 +0200

#1487149 — [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2016-09-20 10:40 +0200
Subject[PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
Message-ID<sjoKS-y5-17@gated-at.bofh.it>
From: Arvind Yadav <arvind.yadav.cs@gmail.com>

Free memory mapping, if init is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/clk/mediatek/clk-mt8173.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
index 10c9860..0ac3aee 100644
--- a/drivers/clk/mediatek/clk-mt8173.c
+++ b/drivers/clk/mediatek/clk-mt8173.c
@@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
 	}
 
 	mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
-	if (!clk_data)
+	if (!clk_data) {
+		iounmap(base);
 		return;
+	}
 
 	mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
 
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1487780 — Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

FromJames Liao <jamesjj.liao@mediatek.com>
Date2016-09-21 05:40 +0200
SubjectRe: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
Message-ID<sjGy6-3Gi-1@gated-at.bofh.it>
In reply to#1487149
On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: James Liao <jamesjj.liao@mediatek.com>

> ---
>  drivers/clk/mediatek/clk-mt8173.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 10c9860..0ac3aee 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
>  	}
>  
>  	mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> -	if (!clk_data)
> +	if (!clk_data) {
> +		iounmap(base);
>  		return;
> +	}
>  
>  	mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
>  

[toc] | [prev] | [next] | [standalone]


#1488320 — Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

FromStephen Boyd <sboyd@codeaurora.org>
Date2016-09-21 20:50 +0200
SubjectRe: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
Message-ID<sjUKJ-496-5@gated-at.bofh.it>
In reply to#1487149
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web