Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487780

Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

From James Liao <jamesjj.liao@mediatek.com>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap
Date 2016-09-21 05:40 +0200
Message-ID <sjGy6-3Gi-1@gated-at.bofh.it> (permalink)
References <sjoKS-y5-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: James Liao <jamesjj.liao@mediatek.com>

> ---
>  drivers/clk/mediatek/clk-mt8173.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 10c9860..0ac3aee 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
>  	}
>  
>  	mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> -	if (!clk_data)
> +	if (!clk_data) {
> +		iounmap(base);
>  		return;
> +	}
>  
>  	mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
>  

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-20 10:40 +0200
  Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by  of_iomap James Liao <jamesjj.liao@mediatek.com> - 2016-09-21 05:40 +0200
  Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by  of_iomap Stephen Boyd <sboyd@codeaurora.org> - 2016-09-21 20:50 +0200

csiph-web