Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484759 > unrolled thread

Re: [PATCH v2] clk: probe common clock drivers earlier

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2016-09-16 10:00 +0200
Last post2016-09-18 18:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-16 10:00 +0200
    Re: [PATCH v2] clk: probe common clock drivers earlier Stephen Boyd <sboyd@codeaurora.org> - 2016-09-17 01:20 +0200
      Re: [PATCH v2] clk: probe common clock drivers earlier Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-17 11:00 +0200
        Re: [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-18 18:30 +0200

#1484759 — Re: [PATCH v2] clk: probe common clock drivers earlier

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-09-16 10:00 +0200
SubjectRe: [PATCH v2] clk: probe common clock drivers earlier
Message-ID<shWdY-1I1-27@gated-at.bofh.it>
Hi Stephen, Greg,


2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
>
> Also, drop the comment since it does not look valuable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
>   - Move clk/ above dma/ since DMA drivers generally enable clk
>
>  drivers/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..ff39051 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
>  # was used and do nothing if so
>  obj-$(CONFIG_PNP)              += pnp/
>  obj-y                          += amba/
> +
> +obj-y                          += clk/
>  # Many drivers will want to use DMA so this has to be made available
>  # really early.
>  obj-$(CONFIG_DMADEVICES)       += dma/
> @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
>  obj-$(CONFIG_VLYNQ)            += vlynq/
>  obj-$(CONFIG_STAGING)          += staging/
>  obj-y                          += platform/
> -#common clk code
> -obj-y                          += clk/
>
>  obj-$(CONFIG_MAILBOX)          += mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/


What do you think of this patch?


Linus game me a positive comment:
https://lkml.org/lkml/2016/7/15/722



-- 
Best Regards
Masahiro Yamada

[toc] | [next] | [standalone]

#1485423

FromStephen Boyd <sboyd@codeaurora.org>
Date2016-09-17 01:20 +0200
Message-ID<siaAh-30p-19@gated-at.bofh.it>
In reply to#1484759
On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Greg,
> 
> 
> 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Several SoCs implement platform drivers for clocks rather than
> > CLK_OF_DECLARE().  Clocks should come earlier because they are
> > prerequisites for many of other drivers.  It will help to mitigate
> > EPROBE_DEFER issues.
> >
> > Also, drop the comment since it does not look valuable.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> >   - Move clk/ above dma/ since DMA drivers generally enable clk
> >
> >  drivers/Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 8f5d076..ff39051 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
> >  # was used and do nothing if so
> >  obj-$(CONFIG_PNP)              += pnp/
> >  obj-y                          += amba/
> > +
> > +obj-y                          += clk/
> >  # Many drivers will want to use DMA so this has to be made available
> >  # really early.
> >  obj-$(CONFIG_DMADEVICES)       += dma/
> > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
> >  obj-$(CONFIG_VLYNQ)            += vlynq/
> >  obj-$(CONFIG_STAGING)          += staging/
> >  obj-y                          += platform/
> > -#common clk code
> > -obj-y                          += clk/
> >
> >  obj-$(CONFIG_MAILBOX)          += mailbox/
> >  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> 
> 
> What do you think of this patch?
> 

I assumed Greg would pick it up given that Mike already acked it.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1485507

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-09-17 11:00 +0200
Message-ID<sijDz-l5-9@gated-at.bofh.it>
In reply to#1485423
On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
> On 09/16, Masahiro Yamada wrote:
> > Hi Stephen, Greg,
> > 
> > 
> > 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > > Several SoCs implement platform drivers for clocks rather than
> > > CLK_OF_DECLARE().  Clocks should come earlier because they are
> > > prerequisites for many of other drivers.  It will help to mitigate
> > > EPROBE_DEFER issues.
> > >
> > > Also, drop the comment since it does not look valuable.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > ---
> > >
> > > Changes in v2:
> > >   - Move clk/ above dma/ since DMA drivers generally enable clk
> > >
> > >  drivers/Makefile | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 8f5d076..ff39051 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
> > >  # was used and do nothing if so
> > >  obj-$(CONFIG_PNP)              += pnp/
> > >  obj-y                          += amba/
> > > +
> > > +obj-y                          += clk/
> > >  # Many drivers will want to use DMA so this has to be made available
> > >  # really early.
> > >  obj-$(CONFIG_DMADEVICES)       += dma/
> > > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
> > >  obj-$(CONFIG_VLYNQ)            += vlynq/
> > >  obj-$(CONFIG_STAGING)          += staging/
> > >  obj-y                          += platform/
> > > -#common clk code
> > > -obj-y                          += clk/
> > >
> > >  obj-$(CONFIG_MAILBOX)          += mailbox/
> > >  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> > 
> > 
> > What do you think of this patch?
> > 
> 
> I assumed Greg would pick it up given that Mike already acked it.

I was going to take it?  It's not in my queue, sorry, can someone please
resend it with the acks and I will pick it up...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1485853

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-09-18 18:30 +0200
Message-ID<siN8C-1Vv-13@gated-at.bofh.it>
In reply to#1485507
Hi Greg,

2016-09-17 17:56 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
>> On 09/16, Masahiro Yamada wrote:

>> >
>> >
>> > What do you think of this patch?
>> >
>>
>> I assumed Greg would pick it up given that Mike already acked it.
>
> I was going to take it?  It's not in my queue, sorry, can someone please
> resend it with the acks and I will pick it up...
>
> thanks,
>
> greg k-h



I did so with Michael's Acked-by:

https://patchwork.kernel.org/patch/9337959/


Thanks!




-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web