Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485507

Re: [PATCH v2] clk: probe common clock drivers earlier

Show all headers | View raw

On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
> On 09/16, Masahiro Yamada wrote:
> > Hi Stephen, Greg,
> > 
> > 
> > 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > > Several SoCs implement platform drivers for clocks rather than
> > > CLK_OF_DECLARE().  Clocks should come earlier because they are
> > > prerequisites for many of other drivers.  It will help to mitigate
> > > EPROBE_DEFER issues.
> > >
> > > Also, drop the comment since it does not look valuable.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > ---
> > >
> > > Changes in v2:
> > >   - Move clk/ above dma/ since DMA drivers generally enable clk
> > >
> > >  drivers/Makefile | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 8f5d076..ff39051 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
> > >  # was used and do nothing if so
> > >  obj-$(CONFIG_PNP)              += pnp/
> > >  obj-y                          += amba/
> > > +
> > > +obj-y                          += clk/
> > >  # Many drivers will want to use DMA so this has to be made available
> > >  # really early.
> > >  obj-$(CONFIG_DMADEVICES)       += dma/
> > > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
> > >  obj-$(CONFIG_VLYNQ)            += vlynq/
> > >  obj-$(CONFIG_STAGING)          += staging/
> > >  obj-y                          += platform/
> > > -#common clk code
> > > -obj-y                          += clk/
> > >
> > >  obj-$(CONFIG_MAILBOX)          += mailbox/
> > >  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> > 
> > 
> > What do you think of this patch?
> > 
> 
> I assumed Greg would pick it up given that Mike already acked it.

I was going to take it?  It's not in my queue, sorry, can someone please
resend it with the acks and I will pick it up...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-16 10:00 +0200
  Re: [PATCH v2] clk: probe common clock drivers earlier Stephen Boyd <sboyd@codeaurora.org> - 2016-09-17 01:20 +0200
    Re: [PATCH v2] clk: probe common clock drivers earlier Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-17 11:00 +0200
      Re: [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-18 18:30 +0200

csiph-web