Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484335 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-09-15 17:50 +0200 |
| Last post | 2016-09-19 13:20 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Arnd Bergmann <arnd@arndb.de> - 2016-09-15 17:50 +0200
Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Chanwoo Choi <cwchoi00@gmail.com> - 2016-09-16 14:30 +0200
RE: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-09-19 09:50 +0200
Re: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-19 13:20 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-09-15 17:50 +0200 |
| Subject | [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency |
| Message-ID | <shH5f-o6-9@gated-at.bofh.it> |
The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
a 'select' statement, and that in turn has a dependency on
PM_DEVFREQ_EVENT, which may be disabled here:
warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
We probably want a 'depends on' here, but other drivers use 'select'
too, so for consistency I'm doing the same.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
---
drivers/devfreq/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 93b6ada06676..41254e702f1e 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
depends on ARCH_ROCKCHIP
select DEVFREQ_EVENT_ROCKCHIP_DFI
select DEVFREQ_GOV_SIMPLE_ONDEMAND
+ select PM_DEVFREQ_EVENT
select PM_OPP
help
This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
--
2.9.0
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Date | 2016-09-16 14:30 +0200 |
| Message-ID | <si0rf-4Fp-17@gated-at.bofh.it> |
| In reply to | #1484335 |
Hi Arnd,
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Best Regards,
Chanwoo Choi
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 93b6ada06676..41254e702f1e 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
> depends on ARCH_ROCKCHIP
> select DEVFREQ_EVENT_ROCKCHIP_DFI
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> + select PM_DEVFREQ_EVENT
> select PM_OPP
> help
> This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2016-09-19 09:50 +0200 |
| Message-ID | <sj1uV-2ya-27@gated-at.bofh.it> |
| In reply to | #1484335 |
[Multipart message — attachments visible in raw view] — view raw
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
Thank you.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Being tested at: https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-4.9-rc
@ The branch above requires additional patches to be tested
(other rockchip support drivers to be merged for 4.9 and COMPILE_TEST retraction for TEGRA)
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2016-09-19 13:20 +0200 |
| Message-ID | <sj4Ma-4KI-21@gated-at.bofh.it> |
| In reply to | #1486219 |
On Mon, Sep 19, 2016 at 9:46 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> 2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
>> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
>> a 'select' statement, and that in turn has a dependency on
>> PM_DEVFREQ_EVENT, which may be disabled here:
>>
>> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>>
>> We probably want a 'depends on' here, but other drivers use 'select'
>> too, so for consistency I'm doing the same.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
>
>
> Thank you.
>
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
I've applied this one directly.
Thanks,
Rafael
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web