Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency

From	Chanwoo Choi <cwchoi00@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
Date	2016-09-16 14:30 +0200
Message-ID	<si0rf-4Fp-17@gated-at.bofh.it> (permalink)
References	<shH5f-o6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
> ---
>  drivers/devfreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 93b6ada06676..41254e702f1e 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
>         depends on ARCH_ROCKCHIP
>         select DEVFREQ_EVENT_ROCKCHIP_DFI
>         select DEVFREQ_GOV_SIMPLE_ONDEMAND
> +       select PM_DEVFREQ_EVENT
>         select PM_OPP
>         help
>            This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
> --
> 2.9.0
>

Thread

[PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Arnd Bergmann <arnd@arndb.de> - 2016-09-15 17:50 +0200
  Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Chanwoo Choi <cwchoi00@gmail.com> - 2016-09-16 14:30 +0200
  RE: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-09-19 09:50 +0200
    Re: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-19 13:20 +0200

csiph-web