Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482961 > unrolled thread
| Started by | Sanchayan Maity <maitysanchayan@gmail.com> |
|---|---|
| First post | 2016-09-14 08:50 +0200 |
| Last post | 2016-09-17 07:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Sanchayan Maity <maitysanchayan@gmail.com> - 2016-09-14 08:50 +0200
Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-09-16 19:20 +0200
Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight maitysanchayan@gmail.com - 2016-09-17 07:00 +0200
| From | Sanchayan Maity <maitysanchayan@gmail.com> |
|---|---|
| Date | 2016-09-14 08:50 +0200 |
| Subject | [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight |
| Message-ID | <shcb8-5My-13@gated-at.bofh.it> |
Use enable-gpios property of PWM backlight driver for backlight
control. While at it also fix the use of brightness levels required
by EDT displays which require inverted PWM's.
Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 8c67dd8..9100bde 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -49,7 +49,10 @@
backlight: backlight {
compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_gpio_bl_on>;
pwms = <&pwm4 0 5000000>;
+ enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
status = "disabled";
};
@@ -614,6 +617,12 @@
>;
};
+ pinctrl_gpio_bl_on: gpioblon {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
+ >;
+ };
+
pinctrl_gpio_keys: gpio1io04grp {
fsl,pins = <
/* Power button */
--
2.9.3
[toc] | [next] | [standalone]
| From | Marcel Ziswiler <marcel.ziswiler@toradex.com> |
|---|---|
| Date | 2016-09-16 19:20 +0200 |
| Subject | Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight |
| Message-ID | <si4XT-7Hc-3@gated-at.bofh.it> |
| In reply to | #1482961 |
On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.
That part I am missing below. Did you forget to include it?
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
>
> backlight: backlight {
> compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> pwms = <&pwm4 0 5000000>;
> + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> status = "disabled";
> };
>
> @@ -614,6 +617,12 @@
> >;
> };
>
> + pinctrl_gpio_bl_on: gpioblon {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> + >;
> + };
> +
> pinctrl_gpio_keys: gpio1io04grp {
> fsl,pins = <
> /* Power button */
[toc] | [prev] | [next] | [standalone]
| From | maitysanchayan@gmail.com |
|---|---|
| Date | 2016-09-17 07:00 +0200 |
| Subject | Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight |
| Message-ID | <sifTj-6oK-1@gated-at.bofh.it> |
| In reply to | #1485187 |
Hello Marcel,
On 16-09-16 13:38:54, Marcel Ziswiler wrote:
> On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> > Use enable-gpios property of PWM backlight driver for backlight
> > control. While at it also fix the use of brightness levels required
> > by EDT displays which require inverted PWM's.
>
> That part I am missing below. Did you forget to include it?
No, actually I missed fixing the commit message. Currently PWM polarity
inversion is not supported and while checking, I kept the brightness
levels as is currently but did not change the commit message.
Will send a v2 and fix this.
Regards,
Sanchayan.
>
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 8c67dd8..9100bde 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -49,7 +49,10 @@
> >
> > backlight: backlight {
> > compatible = "pwm-backlight";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> > pwms = <&pwm4 0 5000000>;
> > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> > status = "disabled";
> > };
> >
> > @@ -614,6 +617,12 @@
> > >;
> > };
> >
> > + pinctrl_gpio_bl_on: gpioblon {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> > + >;
> > + };
> > +
> > pinctrl_gpio_keys: gpio1io04grp {
> > fsl,pins = <
> > /* Power button */
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web