Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1485187

Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight

From Marcel Ziswiler <marcel.ziswiler@toradex.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date 2016-09-16 19:20 +0200
Message-ID <si4XT-7Hc-3@gated-at.bofh.it> (permalink)
References <shcb8-5My-11@gated-at.bofh.it> <shcb8-5My-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.

That part I am missing below. Did you forget to include it?

> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
>  
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_bl_on>;
>  		pwms = <&pwm4 0 5000000>;
> +		enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>  		status = "disabled";
>  	};
>  
> @@ -614,6 +617,12 @@
>  		>;
>  	};
>  
> +	pinctrl_gpio_bl_on: gpioblon {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> +		>;
> +	};
> +
>  	pinctrl_gpio_keys: gpio1io04grp {
>  		fsl,pins = <
>  			/* Power button */

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Sanchayan Maity <maitysanchayan@gmail.com> - 2016-09-14 08:50 +0200
  Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios  property for backlight Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-09-16 19:20 +0200
    Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios  property for backlight maitysanchayan@gmail.com - 2016-09-17 07:00 +0200

csiph-web