Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1483946 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-09-15 12:20 +0200 |
| Last post | 2016-09-16 10:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-15 12:20 +0200
Re: [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:10 +0200
Re: [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:10 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-09-15 12:20 +0200 |
| Subject | [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() |
| Message-ID | <shBVT-5HB-1@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix a double lock bug in SetPSModeWorkItemCallback().
Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock
with mutex")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/staging/rtl8712/rtl871x_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.c b/drivers/staging/rtl8712/rtl871x_pwrctrl.c
index 8f82d85..d464c13 100644
--- a/drivers/staging/rtl8712/rtl871x_pwrctrl.c
+++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.c
@@ -145,7 +145,7 @@ static void SetPSModeWorkItemCallback(struct work_struct *work)
mutex_lock(&pwrpriv->mutex_lock);
if (pwrpriv->pwr_mode == PS_MODE_ACTIVE)
r8712_set_rpwm(padapter, PS_STATE_S4);
- mutex_lock(&pwrpriv->mutex_lock);
+ mutex_unlock(&pwrpriv->mutex_lock);
}
}
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-09-16 10:10 +0200 |
| Subject | Re: [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() |
| Message-ID | <shWnE-21n-15@gated-at.bofh.it> |
| In reply to | #1483946 |
On Thu, Sep 15, 2016 at 10:12:05AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix a double lock bug in SetPSModeWorkItemCallback().
>
> Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock > with mutex")
I don't see that commit id in any tree that I can find, are you sure it
is correct?
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-09-16 10:10 +0200 |
| Subject | Re: [PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() |
| Message-ID | <shWnE-21n-21@gated-at.bofh.it> |
| In reply to | #1484768 |
On Fri, Sep 16, 2016 at 10:01:47AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 10:12:05AM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > Fix a double lock bug in SetPSModeWorkItemCallback().
> >
> > Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock > with mutex")
>
> I don't see that commit id in any tree that I can find, are you sure it
> is correct?
Oh nevermind, I was looking at the wrong tree, sorry, this is fine...
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web