[PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback()
Date	2016-09-15 12:20 +0200
Message-ID	<shBVT-5HB-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix a double lock bug in SetPSModeWorkItemCallback().

Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock
with mutex")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/staging/rtl8712/rtl871x_pwrctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.c b/drivers/staging/rtl8712/rtl871x_pwrctrl.c
index 8f82d85..d464c13 100644
--- a/drivers/staging/rtl8712/rtl871x_pwrctrl.c
+++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.c
@@ -145,7 +145,7 @@ static void SetPSModeWorkItemCallback(struct work_struct *work)
 		mutex_lock(&pwrpriv->mutex_lock);
 		if (pwrpriv->pwr_mode == PS_MODE_ACTIVE)
 			r8712_set_rpwm(padapter, PS_STATE_S4);
-		mutex_lock(&pwrpriv->mutex_lock);
+		mutex_unlock(&pwrpriv->mutex_lock);
 	}
 }

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-15 12:20 +0200
  Re: [PATCH -next] staging: rtl8712: fix double lock bug in  SetPSModeWorkItemCallback() Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:10 +0200
    Re: [PATCH -next] staging: rtl8712: fix double lock bug in  SetPSModeWorkItemCallback() Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:10 +0200

csiph-web