Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480396 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2016-09-10 00:30 +0200 |
| Last post | 2016-09-13 15:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/9] selftests: update filesystems Makefile to work under selftests Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-10 00:30 +0200
Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests Michael Ellerman <mpe@ellerman.id.au> - 2016-09-13 14:00 +0200
Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-13 15:30 +0200
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2016-09-10 00:30 +0200 |
| Subject | [PATCH 2/9] selftests: update filesystems Makefile to work under selftests |
| Message-ID | <sfCt3-jt-9@gated-at.bofh.it> |
Update to work under selftests. dnotify_test will not be run as part of selftests suite and will not included in install targets. It can be built separately for now. Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/filesystems/Makefile | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile index 883010c..f1dce5c 100644 --- a/tools/testing/selftests/filesystems/Makefile +++ b/tools/testing/selftests/filesystems/Makefile @@ -1,5 +1,7 @@ -# List of programs to build -hostprogs-y := dnotify_test +TEST_PROGS := dnotify_test +all: $(TEST_PROGS) -# Tell kbuild to always build the programs -always := $(hostprogs-y) +include ../lib.mk + +clean: + rm -fr dnotify_test -- 2.7.4
[toc] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2016-09-13 14:00 +0200 |
| Message-ID | <sgUxz-1jF-11@gated-at.bofh.it> |
| In reply to | #1480396 |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Update to work under selftests. dnotify_test will not be run as part of > selftests suite and will not included in install targets. It can be built > separately for now. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/filesystems/Makefile | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile > index 883010c..f1dce5c 100644 > --- a/tools/testing/selftests/filesystems/Makefile > +++ b/tools/testing/selftests/filesystems/Makefile > @@ -1,5 +1,7 @@ > -# List of programs to build > -hostprogs-y := dnotify_test > +TEST_PROGS := dnotify_test > +all: $(TEST_PROGS) > > -# Tell kbuild to always build the programs > -always := $(hostprogs-y) > +include ../lib.mk > + > +clean: > + rm -fr dnotify_test That's a complete rewrite of the Makefile, so I don't think there's any value in bringing its content across from Documentation. Better IMHO would be to squash this with the previous patch, so we get a working test under selftests in a single commit. cheers
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2016-09-13 15:30 +0200 |
| Subject | Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests |
| Message-ID | <sgVWG-2uA-53@gated-at.bofh.it> |
| In reply to | #1482393 |
On 09/13/2016 05:56 AM, Michael Ellerman wrote: > Shuah Khan <shuahkh@osg.samsung.com> writes: > >> Update to work under selftests. dnotify_test will not be run as part of >> selftests suite and will not included in install targets. It can be built >> separately for now. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/filesystems/Makefile | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile >> index 883010c..f1dce5c 100644 >> --- a/tools/testing/selftests/filesystems/Makefile >> +++ b/tools/testing/selftests/filesystems/Makefile >> @@ -1,5 +1,7 @@ >> -# List of programs to build >> -hostprogs-y := dnotify_test >> +TEST_PROGS := dnotify_test >> +all: $(TEST_PROGS) >> >> -# Tell kbuild to always build the programs >> -always := $(hostprogs-y) >> +include ../lib.mk >> + >> +clean: >> + rm -fr dnotify_test > > That's a complete rewrite of the Makefile, so I don't think there's any > value in bringing its content across from Documentation. Moving Makefile accomplishes delete at the same time. I can combine the move and updating Makefile into one single patch. > > Better IMHO would be to squash this with the previous patch, so we get a > working test under selftests in a single commit. > > cheers > thanks, -- Shuah
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web