Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482393

Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests

Show all headers | View raw

Shuah Khan <shuahkh@osg.samsung.com> writes:

> Update to work under selftests. dnotify_test will not be run as part of
> selftests suite and will not included in install targets. It can be built
> separately for now.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  tools/testing/selftests/filesystems/Makefile | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile
> index 883010c..f1dce5c 100644
> --- a/tools/testing/selftests/filesystems/Makefile
> +++ b/tools/testing/selftests/filesystems/Makefile
> @@ -1,5 +1,7 @@
> -# List of programs to build
> -hostprogs-y := dnotify_test
> +TEST_PROGS := dnotify_test
> +all: $(TEST_PROGS)
>  
> -# Tell kbuild to always build the programs
> -always := $(hostprogs-y)
> +include ../lib.mk
> +
> +clean:
> +	rm -fr dnotify_test

That's a complete rewrite of the Makefile, so I don't think there's any
value in bringing its content across from Documentation.

Better IMHO would be to squash this with the previous patch, so we get a
working test under selftests in a single commit.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/9] selftests: update filesystems Makefile to work under selftests Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-10 00:30 +0200
  Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests Michael Ellerman <mpe@ellerman.id.au> - 2016-09-13 14:00 +0200
    Re: [PATCH 2/9] selftests: update filesystems Makefile to work under  selftests Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-13 15:30 +0200

csiph-web