Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481111 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-12 12:20 +0200 |
| Last post | 2016-09-13 14:20 +0200 |
| Articles | 6 — 6 participants |
Back to article view | Back to linux.kernel
[PATCH] powerpc/32: add missing \n at end of printk warning message Colin King <colin.king@canonical.com> - 2016-09-12 12:20 +0200
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-12 17:30 +0200
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message Michael Ellerman <mpe@ellerman.id.au> - 2016-09-13 03:30 +0200
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message Joe Perches <joe@perches.com> - 2016-09-12 18:40 +0200
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message Colin Ian King <colin.king@canonical.com> - 2016-09-12 19:00 +0200
Re: powerpc/32: add missing \n at end of printk warning message Michael Ellerman <patch-notifications@ellerman.id.au> - 2016-09-13 14:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 12:20 +0200 |
| Subject | [PATCH] powerpc/32: add missing \n at end of printk warning message |
| Message-ID | <sgwvg-1VB-19@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The message is missing a \n, add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/powerpc/mm/init_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 448685f..b532dd9 100644
--- a/arch/powerpc/mm/init_32.c
+++ b/arch/powerpc/mm/init_32.c
@@ -137,7 +137,7 @@ void __init MMU_init(void)
if (memblock.memory.cnt > 1) {
#ifndef CONFIG_WII
memblock_enforce_memory_limit(memblock.memory.regions[0].size);
- printk(KERN_WARNING "Only using first contiguous memory region");
+ printk(KERN_WARNING "Only using first contiguous memory region\n");
#else
wii_memory_fixups();
#endif
--
2.9.3
[toc] | [next] | [standalone]
| From | Christophe Leroy <christophe.leroy@c-s.fr> |
|---|---|
| Date | 2016-09-12 17:30 +0200 |
| Subject | Re: [PATCH] powerpc/32: add missing \n at end of printk warning message |
| Message-ID | <sgBlf-548-3@gated-at.bofh.it> |
| In reply to | #1481111 |
Le 12/09/2016 à 12:12, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/powerpc/mm/init_32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
> index 448685f..b532dd9 100644
> --- a/arch/powerpc/mm/init_32.c
> +++ b/arch/powerpc/mm/init_32.c
> @@ -137,7 +137,7 @@ void __init MMU_init(void)
> if (memblock.memory.cnt > 1) {
> #ifndef CONFIG_WII
> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
> - printk(KERN_WARNING "Only using first contiguous memory region");
> + printk(KERN_WARNING "Only using first contiguous memory region\n");
This line was already 81 characters long. It is now 83.
I would suggest to use pr_warn() instead in order to shorten the line.
Christophe
> #else
> wii_memory_fixups();
> #endif
>
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2016-09-13 03:30 +0200 |
| Message-ID | <sgKHT-35L-3@gated-at.bofh.it> |
| In reply to | #1481420 |
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 12/09/2016 à 12:12, Colin King a écrit :
>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
>> index 448685f..b532dd9 100644
>> --- a/arch/powerpc/mm/init_32.c
>> +++ b/arch/powerpc/mm/init_32.c
>> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>> if (memblock.memory.cnt > 1) {
>> #ifndef CONFIG_WII
>> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
>> - printk(KERN_WARNING "Only using first contiguous memory region");
>> + printk(KERN_WARNING "Only using first contiguous memory region\n");
>
> This line was already 81 characters long. It is now 83.
That doesn't really bother me.
> I would suggest to use pr_warn() instead in order to shorten the line.
But I do like pr_warn(), it's less shouty.
I'll fix it up when I apply it.
cheers
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-09-12 18:40 +0200 |
| Subject | Re: [PATCH] powerpc/32: add missing \n at end of printk warning message |
| Message-ID | <sgCr0-5K3-13@gated-at.bofh.it> |
| In reply to | #1481111 |
On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > The message is missing a \n, add it. Was this found via inspection or a tool?
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 19:00 +0200 |
| Subject | Re: [PATCH] powerpc/32: add missing \n at end of printk warning message |
| Message-ID | <sgCKl-5RJ-5@gated-at.bofh.it> |
| In reply to | #1481538 |
On 12/09/16 17:34, Joe Perches wrote: > On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> The message is missing a \n, add it. > > Was this found via inspection or a tool? > grep
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <patch-notifications@ellerman.id.au> |
|---|---|
| Date | 2016-09-13 14:20 +0200 |
| Subject | Re: powerpc/32: add missing \n at end of printk warning message |
| Message-ID | <sgUQW-1IH-3@gated-at.bofh.it> |
| In reply to | #1481111 |
On Mon, 2016-12-09 at 10:12:24 UTC, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The message is missing a \n, add it. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3daf3c206992891ac0cec6a54a cheers
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web