Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482079

Re: [PATCH] powerpc/32: add missing \n at end of printk warning message

Show all headers | View raw

Christophe Leroy <christophe.leroy@c-s.fr> writes:

> Le 12/09/2016 à 12:12, Colin King a écrit :
>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
>> index 448685f..b532dd9 100644
>> --- a/arch/powerpc/mm/init_32.c
>> +++ b/arch/powerpc/mm/init_32.c
>> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>>  	if (memblock.memory.cnt > 1) {
>>  #ifndef CONFIG_WII
>>  		memblock_enforce_memory_limit(memblock.memory.regions[0].size);
>> -		printk(KERN_WARNING "Only using first contiguous memory region");
>> +		printk(KERN_WARNING "Only using first contiguous memory region\n");
>
> This line was already 81 characters long. It is now 83.

That doesn't really bother me.

> I would suggest to use pr_warn() instead in order to shorten the line.

But I do like pr_warn(), it's less shouty.

I'll fix it up when I apply it.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc/32: add missing \n at end of printk warning message Colin King <colin.king@canonical.com> - 2016-09-12 12:20 +0200
  Re: [PATCH] powerpc/32: add missing \n at end of printk warning  message Christophe Leroy <christophe.leroy@c-s.fr> - 2016-09-12 17:30 +0200
    Re: [PATCH] powerpc/32: add missing \n at end of printk warning message Michael Ellerman <mpe@ellerman.id.au> - 2016-09-13 03:30 +0200
  Re: [PATCH] powerpc/32: add missing \n at end of printk warning  message Joe Perches <joe@perches.com> - 2016-09-12 18:40 +0200
    Re: [PATCH] powerpc/32: add missing \n at end of printk warning  message Colin Ian King <colin.king@canonical.com> - 2016-09-12 19:00 +0200
  Re: powerpc/32: add missing \n at end of printk warning message Michael Ellerman <patch-notifications@ellerman.id.au> - 2016-09-13 14:20 +0200

csiph-web