Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480520 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2016-09-10 09:20 +0200 |
| Last post | 2016-09-11 06:50 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] ATM-nicstar: Fine-tuning for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:20 +0200
[PATCH 3/5] ATM-nicstar: Improve another size determination in ns_init_card() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200
[PATCH 4/5] ATM-nicstar: Refactor a kmalloc() call in ns_init_card() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200
[PATCH 5/5] ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200
Re: [PATCH 0/5] ATM-nicstar: Fine-tuning for three function implementations David Miller <davem@davemloft.net> - 2016-09-11 06:50 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-10 09:20 +0200 |
| Subject | [PATCH 0/5] ATM-nicstar: Fine-tuning for three function implementations |
| Message-ID | <sfKJY-5yk-3@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 10 Sep 2016 09:10:01 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use kmalloc_array() in get_scq() Improve another size determination in get_scq() Improve another size determination in ns_init_card() Refactor a kmalloc() call in ns_init_card() Refactor a dev_alloc_skb() call in dequeue_rx() drivers/atm/nicstar.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 2.10.0
[toc] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-10 09:30 +0200 |
| Subject | [PATCH 3/5] ATM-nicstar: Improve another size determination in ns_init_card() |
| Message-ID | <sfKTD-5B9-1@gated-at.bofh.it> |
| In reply to | #1480520 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 10 Sep 2016 08:30:09 +0200 Replace the specification of a data structure by a reference for a field in a local variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/atm/nicstar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 96062e1..ef977bf 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -611,7 +611,7 @@ static int ns_init_card(int i, struct pci_dev *pcidev) for (j = 0; j < card->rct_size; j++) ns_write_sram(card, j * 4, u32d, 4); - memset(card->vcmap, 0, NS_MAX_RCTSIZE * sizeof(vc_map)); + memset(card->vcmap, 0, sizeof(card->vcmap)); for (j = 0; j < NS_FRSCD_NUM; j++) card->scd2vc[j] = NULL; -- 2.10.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-10 09:30 +0200 |
| Subject | [PATCH 4/5] ATM-nicstar: Refactor a kmalloc() call in ns_init_card() |
| Message-ID | <sfKTD-5B9-3@gated-at.bofh.it> |
| In reply to | #1480520 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 08:48:17 +0200
* The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.
* Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/atm/nicstar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index ef977bf..04f5781 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -370,7 +370,8 @@ static int ns_init_card(int i, struct pci_dev *pcidev)
return error;
}
- if ((card = kmalloc(sizeof(ns_dev), GFP_KERNEL)) == NULL) {
+ card = kmalloc(sizeof(*card), GFP_KERNEL);
+ if (!card) {
printk
("nicstar%d: can't allocate memory for device structure.\n",
i);
--
2.10.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-10 09:30 +0200 |
| Subject | [PATCH 5/5] ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx() |
| Message-ID | <sfKTD-5B9-7@gated-at.bofh.it> |
| In reply to | #1480520 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 08:56:03 +0200
The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/atm/nicstar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index 04f5781..c7296b5 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -2023,7 +2023,8 @@ static void dequeue_rx(ns_dev * card, ns_rsqe * rsqe)
cell = skb->data;
for (i = ns_rsqe_cellcount(rsqe); i; i--) {
- if ((sb = dev_alloc_skb(NS_SMSKBSIZE)) == NULL) {
+ sb = dev_alloc_skb(NS_SMSKBSIZE);
+ if (!sb) {
printk
("nicstar%d: Can't allocate buffers for aal0.\n",
card->index);
--
2.10.0
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-09-11 06:50 +0200 |
| Message-ID | <sg4Sm-1vD-9@gated-at.bofh.it> |
| In reply to | #1480520 |
From: SF Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 10 Sep 2016 09:15:37 +0200 > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 10 Sep 2016 09:10:01 +0200 > > A few update suggestions were taken into account > from static source code analysis. Series applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web