Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480524
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 5/5] ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx() |
| Date | 2016-09-10 09:30 +0200 |
| Message-ID | <sfKTD-5B9-7@gated-at.bofh.it> (permalink) |
| References | <sfKJY-5yk-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 10 Sep 2016 08:56:03 +0200
The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/atm/nicstar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index 04f5781..c7296b5 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -2023,7 +2023,8 @@ static void dequeue_rx(ns_dev * card, ns_rsqe * rsqe)
cell = skb->data;
for (i = ns_rsqe_cellcount(rsqe); i; i--) {
- if ((sb = dev_alloc_skb(NS_SMSKBSIZE)) == NULL) {
+ sb = dev_alloc_skb(NS_SMSKBSIZE);
+ if (!sb) {
printk
("nicstar%d: Can't allocate buffers for aal0.\n",
card->index);
--
2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] ATM-nicstar: Fine-tuning for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:20 +0200 [PATCH 3/5] ATM-nicstar: Improve another size determination in ns_init_card() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200 [PATCH 4/5] ATM-nicstar: Refactor a kmalloc() call in ns_init_card() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200 [PATCH 5/5] ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-10 09:30 +0200 Re: [PATCH 0/5] ATM-nicstar: Fine-tuning for three function implementations David Miller <davem@davemloft.net> - 2016-09-11 06:50 +0200
csiph-web