Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480446 > unrolled thread
| Started by | Jun Li <jun.li@nxp.com> |
|---|---|
| First post | 2016-09-10 02:30 +0200 |
| Last post | 2016-09-12 07:50 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-10 02:30 +0200
Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-09-10 04:30 +0200
Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-09-12 04:30 +0200
RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-12 05:20 +0200
RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-12 07:50 +0200
| From | Jun Li <jun.li@nxp.com> |
|---|---|
| Date | 2016-09-10 02:30 +0200 |
| Subject | RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) |
| Message-ID | <sfElc-1uj-11@gated-at.bofh.it> |
Hi Guenter, > -----Original Message----- > From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > owner@vger.kernel.org] On Behalf Of Guenter Roeck > Sent: Wednesday, August 24, 2016 5:11 AM > To: Felipe Balbi <felipe.balbi@linux.intel.com> > Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce > Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; > Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus > <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux- > usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org> > Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) > > This driver implements the USB Type-C Power Delivery state machine > for both source and sink ports. Alternate mode support is not > fully implemented. > > The driver attaches to the USB Type-C class code implemented in > the following patches. > > usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY > usb: USB Type-C connector class > > This driver only implements the state machine. Lower level drivers are > responsible for > - Reporting VBUS status and activating VBUS > - Setting CC lines and providing CC line status > - Setting line polarity > - Activating and deactivating VCONN > - Setting the current limit > - Activating and deactivating PD message transfers > - Sending and receiving PD messages > > The driver provides both a functional API as well as callbacks for > lower level drivers. > > Signed-off-by: Guenter Roeck <groeck@chromium.org> > --- A specific question, if power sink wants to request a new power level after SNK_READY, how to handle it with this tcpm? Thanks Li Jun
[toc] | [next] | [standalone]
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Date | 2016-09-10 04:30 +0200 |
| Message-ID | <sfGdk-2HO-15@gated-at.bofh.it> |
| In reply to | #1480446 |
On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote: > Hi Guenter, > >> -----Original Message----- >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- >> owner@vger.kernel.org] On Behalf Of Guenter Roeck >> Sent: Wednesday, August 24, 2016 5:11 AM >> To: Felipe Balbi <felipe.balbi@linux.intel.com> >> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce >> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; >> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux- >> usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org> >> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) >> >> This driver implements the USB Type-C Power Delivery state machine >> for both source and sink ports. Alternate mode support is not >> fully implemented. >> >> The driver attaches to the USB Type-C class code implemented in >> the following patches. >> >> usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY >> usb: USB Type-C connector class >> >> This driver only implements the state machine. Lower level drivers are >> responsible for >> - Reporting VBUS status and activating VBUS >> - Setting CC lines and providing CC line status >> - Setting line polarity >> - Activating and deactivating VCONN >> - Setting the current limit >> - Activating and deactivating PD message transfers >> - Sending and receiving PD messages >> >> The driver provides both a functional API as well as callbacks for >> lower level drivers. >> >> Signed-off-by: Guenter Roeck <groeck@chromium.org> >> --- > > A specific question, if power sink wants to request a new power level > after SNK_READY, how to handle it with this tcpm? > So far I have considered the required power level to be static, based on our curent implementations. That should be easy to change, though, with an additional API function, to be called from a low level driver. Do you have that requirement, and would such a function meet your needs ? Thanks, Guenter
[toc] | [prev] | [next] | [standalone]
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Date | 2016-09-12 04:30 +0200 |
| Message-ID | <sgpaq-5Nb-7@gated-at.bofh.it> |
| In reply to | #1480477 |
On Sun, Sep 11, 2016 at 7:16 PM, Jun Li <jun.li@nxp.com> wrote: > Hi Guenter > >> -----Original Message----- >> From: Guenter Roeck [mailto:groeck@google.com] >> Sent: Saturday, September 10, 2016 10:23 AM >> To: Jun Li <jun.li@nxp.com> >> Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi >> <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani >> <chandra.sekhar.anagani@intel.com>; Bruce Ashfield >> <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav Tipnis >> <pranav.tipnis@intel.com>; Heikki Krogerus >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux- >> usb@vger.kernel.org >> Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) >> >> On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote: >> > Hi Guenter, >> > >> >> -----Original Message----- >> >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- >> >> owner@vger.kernel.org] On Behalf Of Guenter Roeck >> >> Sent: Wednesday, August 24, 2016 5:11 AM >> >> To: Felipe Balbi <felipe.balbi@linux.intel.com> >> >> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce >> >> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; >> >> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus >> >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; >> >> linux- usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org> >> >> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager >> >> (tcpm) >> >> >> >> This driver implements the USB Type-C Power Delivery state machine >> >> for both source and sink ports. Alternate mode support is not fully >> >> implemented. >> >> >> >> The driver attaches to the USB Type-C class code implemented in the >> >> following patches. >> >> >> >> usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY >> >> usb: USB Type-C connector class >> >> >> >> This driver only implements the state machine. Lower level drivers >> >> are responsible for >> >> - Reporting VBUS status and activating VBUS >> >> - Setting CC lines and providing CC line status >> >> - Setting line polarity >> >> - Activating and deactivating VCONN >> >> - Setting the current limit >> >> - Activating and deactivating PD message transfers >> >> - Sending and receiving PD messages >> >> >> >> The driver provides both a functional API as well as callbacks for >> >> lower level drivers. >> >> >> >> Signed-off-by: Guenter Roeck <groeck@chromium.org> >> >> --- >> > >> > A specific question, if power sink wants to request a new power level >> > after SNK_READY, how to handle it with this tcpm? >> > >> >> So far I have considered the required power level to be static, based on >> our curent implementations. That should be easy to change, though, with an >> additional API function, to be called from a low level driver. >> Do you have that requirement, and would such a function meet your needs ? >> > > So you are going to make port->tcpc->config to be dynamic to meet my need? > What would that help ? How would tcpm get informed that the power requirements changed without an API function telling it that power requirements changed ? Guenter
[toc] | [prev] | [next] | [standalone]
| From | Jun Li <jun.li@nxp.com> |
|---|---|
| Date | 2016-09-12 05:20 +0200 |
| Message-ID | <sgpWN-6ix-1@gated-at.bofh.it> |
| In reply to | #1480894 |
> -----Original Message----- > From: Guenter Roeck [mailto:groeck@google.com] > Sent: Monday, September 12, 2016 10:24 AM > To: Jun Li <jun.li@nxp.com> > Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi > <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani > <chandra.sekhar.anagani@intel.com>; Bruce Ashfield > <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav Tipnis > <pranav.tipnis@intel.com>; Heikki Krogerus > <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux- > usb@vger.kernel.org > Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) > > On Sun, Sep 11, 2016 at 7:16 PM, Jun Li <jun.li@nxp.com> wrote: > > Hi Guenter > > > >> -----Original Message----- > >> From: Guenter Roeck [mailto:groeck@google.com] > >> Sent: Saturday, September 10, 2016 10:23 AM > >> To: Jun Li <jun.li@nxp.com> > >> Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi > >> <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani > >> <chandra.sekhar.anagani@intel.com>; Bruce Ashfield > >> <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav > >> Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus > >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; > >> linux- usb@vger.kernel.org > >> Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager > >> (tcpm) > >> > >> On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote: > >> > Hi Guenter, > >> > > >> >> -----Original Message----- > >> >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > >> >> owner@vger.kernel.org] On Behalf Of Guenter Roeck > >> >> Sent: Wednesday, August 24, 2016 5:11 AM > >> >> To: Felipe Balbi <felipe.balbi@linux.intel.com> > >> >> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; > >> >> Bruce Ashfield <bruce.ashfield@windriver.com>; Bin Gao > >> >> <bin.gao@intel.com>; Pranav Tipnis <pranav.tipnis@intel.com>; > >> >> Heikki Krogerus <heikki.krogerus@linux.intel.com>; > >> >> linux-kernel@vger.kernel.org; > >> >> linux- usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org> > >> >> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager > >> >> (tcpm) > >> >> > >> >> This driver implements the USB Type-C Power Delivery state machine > >> >> for both source and sink ports. Alternate mode support is not > >> >> fully implemented. > >> >> > >> >> The driver attaches to the USB Type-C class code implemented in > >> >> the following patches. > >> >> > >> >> usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C > PHY > >> >> usb: USB Type-C connector class > >> >> > >> >> This driver only implements the state machine. Lower level drivers > >> >> are responsible for > >> >> - Reporting VBUS status and activating VBUS > >> >> - Setting CC lines and providing CC line status > >> >> - Setting line polarity > >> >> - Activating and deactivating VCONN > >> >> - Setting the current limit > >> >> - Activating and deactivating PD message transfers > >> >> - Sending and receiving PD messages > >> >> > >> >> The driver provides both a functional API as well as callbacks for > >> >> lower level drivers. > >> >> > >> >> Signed-off-by: Guenter Roeck <groeck@chromium.org> > >> >> --- > >> > > >> > A specific question, if power sink wants to request a new power > >> > level after SNK_READY, how to handle it with this tcpm? > >> > > >> > >> So far I have considered the required power level to be static, based > >> on our curent implementations. That should be easy to change, though, > >> with an additional API function, to be called from a low level driver. > >> Do you have that requirement, and would such a function meet your > needs ? > >> > > > > So you are going to make port->tcpc->config to be dynamic to meet my > need? > > > What would that help ? How would tcpm get informed that the power > requirements changed without an API function telling it that power > requirements changed ? Of cos I agree an additional API is required, I am just wondering how that API will be look like, as current request build is according to port->tcpc->config. Li Jun > > Guenter
[toc] | [prev] | [next] | [standalone]
| From | Jun Li <jun.li@nxp.com> |
|---|---|
| Date | 2016-09-12 07:50 +0200 |
| Message-ID | <sgpaq-5Nb-9@gated-at.bofh.it> |
| In reply to | #1480477 |
Hi Guenter > -----Original Message----- > From: Guenter Roeck [mailto:groeck@google.com] > Sent: Saturday, September 10, 2016 10:23 AM > To: Jun Li <jun.li@nxp.com> > Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi > <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani > <chandra.sekhar.anagani@intel.com>; Bruce Ashfield > <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav Tipnis > <pranav.tipnis@intel.com>; Heikki Krogerus > <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux- > usb@vger.kernel.org > Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) > > On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote: > > Hi Guenter, > > > >> -----Original Message----- > >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > >> owner@vger.kernel.org] On Behalf Of Guenter Roeck > >> Sent: Wednesday, August 24, 2016 5:11 AM > >> To: Felipe Balbi <felipe.balbi@linux.intel.com> > >> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce > >> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; > >> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus > >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; > >> linux- usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org> > >> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager > >> (tcpm) > >> > >> This driver implements the USB Type-C Power Delivery state machine > >> for both source and sink ports. Alternate mode support is not fully > >> implemented. > >> > >> The driver attaches to the USB Type-C class code implemented in the > >> following patches. > >> > >> usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY > >> usb: USB Type-C connector class > >> > >> This driver only implements the state machine. Lower level drivers > >> are responsible for > >> - Reporting VBUS status and activating VBUS > >> - Setting CC lines and providing CC line status > >> - Setting line polarity > >> - Activating and deactivating VCONN > >> - Setting the current limit > >> - Activating and deactivating PD message transfers > >> - Sending and receiving PD messages > >> > >> The driver provides both a functional API as well as callbacks for > >> lower level drivers. > >> > >> Signed-off-by: Guenter Roeck <groeck@chromium.org> > >> --- > > > > A specific question, if power sink wants to request a new power level > > after SNK_READY, how to handle it with this tcpm? > > > > So far I have considered the required power level to be static, based on > our curent implementations. That should be easy to change, though, with an > additional API function, to be called from a low level driver. > Do you have that requirement, and would such a function meet your needs ? > So you are going to make port->tcpc->config to be dynamic to meet my need? Li Jun > Thanks, > Guenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web