Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

From	Guenter Roeck <groeck@google.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
Date	2016-09-10 04:30 +0200
Message-ID	<sfGdk-2HO-15@gated-at.bofh.it> (permalink)
References	<s9rh0-140-27@gated-at.bofh.it> <s9rh1-140-55@gated-at.bofh.it> <sfElc-1uj-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote:
> Hi Guenter,
>
>> -----Original Message-----
>> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
>> owner@vger.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce
>> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>;
>> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus
>> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux-
>> usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org>
>> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
>>
>> This driver implements the USB Type-C Power Delivery state machine
>> for both source and sink ports. Alternate mode support is not
>> fully implemented.
>>
>> The driver attaches to the USB Type-C class code implemented in
>> the following patches.
>>
>>       usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY
>>       usb: USB Type-C connector class
>>
>> This driver only implements the state machine. Lower level drivers are
>> responsible for
>> - Reporting VBUS status and activating VBUS
>> - Setting CC lines and providing CC line status
>> - Setting line polarity
>> - Activating and deactivating VCONN
>> - Setting the current limit
>> - Activating and deactivating PD message transfers
>> - Sending and receiving PD messages
>>
>> The driver provides both a functional API as well as callbacks for
>> lower level drivers.
>>
>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>> ---
>
> A specific question, if power sink wants to request a new power level
> after SNK_READY, how to handle it with this tcpm?
>

So far I have considered the required power level to be static, based
on our curent implementations. That should be easy to change, though,
with an additional API function, to be called from a low level driver.
Do you have that requirement, and would such a function meet your
needs ?

Thanks,
Guenter

Thread

RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-10 02:30 +0200
  Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-09-10 04:30 +0200
    Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-09-12 04:30 +0200
      RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-12 05:20 +0200
    RE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm) Jun Li <jun.li@nxp.com> - 2016-09-12 07:50 +0200

csiph-web