Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477341 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-09-06 15:00 +0200 |
| Last post | 2016-09-09 12:10 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann <arnd@arndb.de> - 2016-09-06 15:00 +0200
Re: [PATCH] usb: phy: add USB_SUPPORT dependency Hans de Goede <hdegoede@redhat.com> - 2016-09-07 11:40 +0200
Re: [PATCH] usb: phy: add USB_SUPPORT dependency Kishon Vijay Abraham I <kishon@ti.com> - 2016-09-08 15:40 +0200
[PATCH] phy-sun4i-usb: select 'USB_COMMON' Arnd Bergmann <arnd@arndb.de> - 2016-09-09 11:30 +0200
Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' Hans de Goede <hdegoede@redhat.com> - 2016-09-09 11:50 +0200
Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' Arnd Bergmann <arnd@arndb.de> - 2016-09-09 12:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-09-06 15:00 +0200 |
| Subject | [PATCH] usb: phy: add USB_SUPPORT dependency |
| Message-ID | <seo8T-29v-33@gated-at.bofh.it> |
The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
USB core layer, and it fails to build when that is not provided:
drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy'
We already have a couple of other PHY drivers with a dependency
on USB_SUPPORT, so that seems to be the easiest fix here.
An alternative would be to adjust the #ifdef in include/linux/usb/of.h
to also check for CONFIG_USB_SUPPORT.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c42ddf3c8ed8..985dff8558e5 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -260,6 +260,7 @@ config PHY_SUN4I_USB
depends on RESET_CONTROLLER
depends on EXTCON
depends on POWER_SUPPLY
+ depends on USB_SUPPORT
select GENERIC_PHY
help
Enable this to support the transceiver that is part of Allwinner
--
2.9.0
[toc] | [next] | [standalone]
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2016-09-07 11:40 +0200 |
| Message-ID | <seHuN-6ml-11@gated-at.bofh.it> |
| In reply to | #1477341 |
Hi,
On 06-09-16 14:54, Arnd Bergmann wrote:
> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
> USB core layer, and it fails to build when that is not provided:
>
> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy'
>
> We already have a couple of other PHY drivers with a dependency
> on USB_SUPPORT, so that seems to be the easiest fix here.
>
> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
> to also check for CONFIG_USB_SUPPORT.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
Good catch, patch LGTM:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index c42ddf3c8ed8..985dff8558e5 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -260,6 +260,7 @@ config PHY_SUN4I_USB
> depends on RESET_CONTROLLER
> depends on EXTCON
> depends on POWER_SUPPLY
> + depends on USB_SUPPORT
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2016-09-08 15:40 +0200 |
| Message-ID | <sf7IC-6nq-15@gated-at.bofh.it> |
| In reply to | #1478114 |
On Wednesday 07 September 2016 03:01 PM, Hans de Goede wrote:
> Hi,
>
> On 06-09-16 14:54, Arnd Bergmann wrote:
>> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
>> USB core layer, and it fails to build when that is not provided:
>>
>> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
>> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to
>> `of_usb_get_dr_mode_by_phy'
>>
>> We already have a couple of other PHY drivers with a dependency
>> on USB_SUPPORT, so that seems to be the easiest fix here.
>>
>> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
>> to also check for CONFIG_USB_SUPPORT.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
>
> Good catch, patch LGTM:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
merged, thanks.
-Kishon
>
> Regards,
>
> Hans
>
>
>
>> ---
>> drivers/phy/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index c42ddf3c8ed8..985dff8558e5 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -260,6 +260,7 @@ config PHY_SUN4I_USB
>> depends on RESET_CONTROLLER
>> depends on EXTCON
>> depends on POWER_SUPPLY
>> + depends on USB_SUPPORT
>> select GENERIC_PHY
>> help
>> Enable this to support the transceiver that is part of Allwinner
>>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-09-09 11:30 +0200 |
| Subject | [PATCH] phy-sun4i-usb: select 'USB_COMMON' |
| Message-ID | <sfqie-12l-31@gated-at.bofh.it> |
| In reply to | #1479233 |
In commit "usb: phy: add USB_SUPPORT dependency", I tried to fix the dependency for this driver, but unfortunately I missed that we need both USB_COMMON and USB_SUPPORT here, and we can still get the same link error in the much rarer case that USB_COMMON is a loadable module and the phy driver is build-in: drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to `of_usb_get_dr_mode_by_phy' This adds the select, hopefully fixing it properly this time. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- I see the original patch hasn't made it into linux-next yet, so ideally just fold this patch into the first one. Sorry for not getting it right the first time around. diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 985dff8558e5..c717f306d131 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -262,6 +262,7 @@ config PHY_SUN4I_USB depends on POWER_SUPPLY depends on USB_SUPPORT select GENERIC_PHY + select USB_COMMON help Enable this to support the transceiver that is part of Allwinner sunxi SoCs.
[toc] | [prev] | [next] | [standalone]
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2016-09-09 11:50 +0200 |
| Subject | Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' |
| Message-ID | <sfqBA-18C-25@gated-at.bofh.it> |
| In reply to | #1479793 |
Hi, On 09-09-16 11:25, Arnd Bergmann wrote: > In commit "usb: phy: add USB_SUPPORT dependency", I tried to > fix the dependency for this driver, but unfortunately I missed > that we need both USB_COMMON and USB_SUPPORT here, and we > can still get the same link error in the much rarer case > that USB_COMMON is a loadable module and the phy driver is > build-in: > > drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': > phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to `of_usb_get_dr_mode_by_phy' > > This adds the select, hopefully fixing it properly this time. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for catching this: Reviewed-by: Hans de Goede <hdegoede@redhat.com> > --- > I see the original patch hasn't made it into linux-next > yet, so ideally just fold this patch into the first one. The original patch is in 4.8-rc# (it got there after rc1). Regards, Hans > > Sorry for not getting it right the first time around. > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 985dff8558e5..c717f306d131 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -262,6 +262,7 @@ config PHY_SUN4I_USB > depends on POWER_SUPPLY > depends on USB_SUPPORT > select GENERIC_PHY > + select USB_COMMON > help > Enable this to support the transceiver that is part of Allwinner > sunxi SoCs. >
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-09-09 12:10 +0200 |
| Subject | Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' |
| Message-ID | <sfqUV-1ud-23@gated-at.bofh.it> |
| In reply to | #1479805 |
On Friday, September 9, 2016 11:42:19 AM CEST Hans de Goede wrote: > > --- > > I see the original patch hasn't made it into linux-next > > yet, so ideally just fold this patch into the first one. > > The original patch is in 4.8-rc# (it got there after rc1). To clarify: I didn't mean it should be folded into the patch that introduced the symbol, but instead should be folded into my first attempt at fixing it. Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web