[PATCH] usb: phy: add USB_SUPPORT dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] usb: phy: add USB_SUPPORT dependency
Date	2016-09-06 15:00 +0200
Message-ID	<seo8T-29v-33@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
USB core layer, and it fails to build when that is not provided:

drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy'

We already have a couple of other PHY drivers with a dependency
on USB_SUPPORT, so that seems to be the easiest fix here.

An alternative would be to adjust the #ifdef in include/linux/usb/of.h
to also check for CONFIG_USB_SUPPORT.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c42ddf3c8ed8..985dff8558e5 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -260,6 +260,7 @@ config PHY_SUN4I_USB
 	depends on RESET_CONTROLLER
 	depends on EXTCON
 	depends on POWER_SUPPLY
+	depends on USB_SUPPORT
 	select GENERIC_PHY
 	help
 	  Enable this to support the transceiver that is part of Allwinner
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann <arnd@arndb.de> - 2016-09-06 15:00 +0200
  Re: [PATCH] usb: phy: add USB_SUPPORT dependency Hans de Goede <hdegoede@redhat.com> - 2016-09-07 11:40 +0200
    Re: [PATCH] usb: phy: add USB_SUPPORT dependency Kishon Vijay Abraham I <kishon@ti.com> - 2016-09-08 15:40 +0200
      [PATCH] phy-sun4i-usb: select 'USB_COMMON' Arnd Bergmann <arnd@arndb.de> - 2016-09-09 11:30 +0200
        Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' Hans de Goede <hdegoede@redhat.com> - 2016-09-09 11:50 +0200
          Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' Arnd Bergmann <arnd@arndb.de> - 2016-09-09 12:10 +0200

csiph-web