Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477140 > unrolled thread

[PATCH] [media] coda: add missing header dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH] [media] coda: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-06 10:00 +0200
    Re: [PATCH] [media] coda: add missing header dependencies Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-06 11:30 +0200
    Re: [PATCH] [media] coda: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-06 11:30 +0200

#1477140 — [PATCH] [media] coda: add missing header dependencies

We get 1 warning when building kernel with W=1:
drivers/media/platform/coda/coda-h264.c:22:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes]

In fact, this function is declared in coda.h, so this patch
add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/media/platform/coda/coda-h264.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
index 456773a..09dfcca 100644
--- a/drivers/media/platform/coda/coda-h264.c
+++ b/drivers/media/platform/coda/coda-h264.c
@@ -13,6 +13,7 @@
 
 #include <linux/kernel.h>
 #include <linux/string.h>
+#include <coda.h>
 
 static const u8 coda_filler_nal[14] = { 0x00, 0x00, 0x00, 0x01, 0x0c, 0xff,
 			0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x80 };
-- 
2.7.4

[toc] | [next] | [standalone]

#1477219

Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann:
> On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
> >  #include <linux/kernel.h>
> >  #include <linux/string.h>
> > +#include <coda.h>
> > 
> 
> by convention, we tend to write this as
> 
> #include "coda.h"
> 
> otherwise the patch looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Same here, make that

+
+#include "coda.h"

and feel free to add
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

thanks
Philipp

[toc] | [prev] | [next] | [standalone]

#1477221

On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
>  #include <linux/kernel.h>
>  #include <linux/string.h>
> +#include <coda.h>
> 

by convention, we tend to write this as

#include "coda.h"

otherwise the patch looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web