Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477219

Re: [PATCH] [media] coda: add missing header dependencies

From Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] [media] coda: add missing header dependencies
Date 2016-09-06 11:30 +0200
Message-ID <sekRF-5Z-23@gated-at.bofh.it> (permalink)
References <sejsu-7qJ-23@gated-at.bofh.it> <sekRF-5Z-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann:
> On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
> >  #include <linux/kernel.h>
> >  #include <linux/string.h>
> > +#include <coda.h>
> > 
> 
> by convention, we tend to write this as
> 
> #include "coda.h"
> 
> otherwise the patch looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Same here, make that

+
+#include "coda.h"

and feel free to add
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

thanks
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] coda: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-06 10:00 +0200
  Re: [PATCH] [media] coda: add missing header dependencies Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-06 11:30 +0200
  Re: [PATCH] [media] coda: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-06 11:30 +0200

csiph-web