Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475488 > unrolled thread

Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls Arnd Bergmann <arnd@arndb.de> - 2016-09-03 00:50 +0200
    Re: [PATCH] doc: ioctl: Add some clarifications to  botching-up-ioctls Jonathan Corbet <corbet@lwn.net> - 2016-09-06 14:10 +0200

#1475488 — Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote:
> - The guide currently says to pad the structure to a multiple of
>   64-bits. This is not necessary in cases where the structure contains
>   no 64-bit types. Clarify this concept to avoid unnecessary padding.
> - When using __u64 to hold user pointers, blindly trying to do a cast to
>   a void __user * may generate a warning on 32-bit systems about a cast
>   from an integer to a pointer of different size. There is a macro to
>   deal with this which hides an ugly double cast. Add a reference to
>   this macro.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> 

Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

[toc] | [next] | [standalone]

#1477305 — Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

On Sat, 03 Sep 2016 00:44:02 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote:
> > - The guide currently says to pad the structure to a multiple of
> >   64-bits. This is not necessary in cases where the structure contains
> >   no 64-bit types. Clarify this concept to avoid unnecessary padding.
> > - When using __u64 to hold user pointers, blindly trying to do a cast to
> >   a void __user * may generate a warning on 32-bit systems about a cast
> >   from an integer to a pointer of different size. There is a macro to
> >   deal with this which hides an ugly double cast. Add a reference to
> >   this macro.
> > 
> > Signed-off-by: Laura Abbott <labbott@redhat.com>
> >   
> 
> Looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Applied to the docs tree, thanks.

jon

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web