Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls
Date	2016-09-03 00:50 +0200
Message-ID	<sd5rA-5sw-9@gated-at.bofh.it> (permalink)
References	<sd5rz-5sw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote:
> - The guide currently says to pad the structure to a multiple of
>   64-bits. This is not necessary in cases where the structure contains
>   no 64-bit types. Clarify this concept to avoid unnecessary padding.
> - When using __u64 to hold user pointers, blindly trying to do a cast to
>   a void __user * may generate a warning on 32-bit systems about a cast
>   from an integer to a pointer of different size. There is a macro to
>   deal with this which hides an ugly double cast. Add a reference to
>   this macro.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> 

Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls Arnd Bergmann <arnd@arndb.de> - 2016-09-03 00:50 +0200
  Re: [PATCH] doc: ioctl: Add some clarifications to  botching-up-ioctls Jonathan Corbet <corbet@lwn.net> - 2016-09-06 14:10 +0200

csiph-web