Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475008 > unrolled thread

[PATCH 3/3] staging: rtl8712: fixed comment style and space indent

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Louie Lu <louie.lu@hopebaytech.com> - 2016-09-02 12:20 +0200
    Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space  indent Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 15:00 +0200
      Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space  indent Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 15:10 +0200
      Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Louie Lu <louie.lu@hopebaytech.com> - 2016-09-02 15:10 +0200

#1475008 — [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

fixed comment style and space indent report from checkpatch:

* WARNING: Statements should start on a tabstop
* WARNING: Block comments use * on subsequent lines
* WARNING: suspect code indent for conditional statements (16, 32)

Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
 1 file changed, 22 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index e205adf..5c05f21 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -422,7 +422,8 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
 			    (u8)_FAIL)
 				ret = -EOPNOTSUPP;
 		} else {
-			/* don't update "psecuritypriv->PrivacyAlgrthm" and
+			/* 
+			 * don't update "psecuritypriv->PrivacyAlgrthm" and
 			 * "psecuritypriv->PrivacyKeyIndex=keyid", but can
 			 * r8712_set_key to fw/cam
 			 */
@@ -664,7 +665,7 @@ static int r8711_wx_set_freq(struct net_device *dev,
 	struct iw_freq *fwrq = &wrqu->freq;
 	int rc = 0;
 
-/* If setting by frequency, convert to a channel */
+	/* If setting by frequency, convert to a channel */
 	if ((fwrq->e == 1) &&
 	  (fwrq->m >= (int) 2.412e8) &&
 	  (fwrq->m <= (int) 2.487e8)) {
@@ -827,7 +828,8 @@ static int r871x_wx_set_pmkid(struct net_device *dev,
 		for (j = 0; j < NUM_PMKID_CACHE; j++) {
 			if (!memcmp(psecuritypriv->PMKIDList[j].Bssid,
 			    strIssueBssid, ETH_ALEN)) {
-				/* BSSID is matched, the same AP => Remove
+				/* 
+				 *BSSID is matched, the same AP => Remove
 				 * this PMKID information and reset it.
 				 */
 				eth_zero_addr(psecuritypriv->PMKIDList[j].Bssid);
@@ -870,11 +872,13 @@ static int r8711_wx_get_range(struct net_device *dev,
 
 	wrqu->data.length = sizeof(*range);
 	memset(range, 0, sizeof(*range));
-	/* Let's try to keep this struct in the same order as in
+	/* 
+	 * Let's try to keep this struct in the same order as in
 	 * linux/include/wireless.h
 	 */
 
-	/* TODO: See what values we can set, and remove the ones we can't
+	/* 
+	 * TODO: See what values we can set, and remove the ones we can't
 	 * set, or fill them with some default data.
 	 */
 	/* ~5 Mb/s real (802.11b) */
@@ -1714,7 +1718,8 @@ static int r871x_wx_set_auth(struct net_device *dev,
 		}
 		break;
 	case IW_AUTH_DROP_UNENCRYPTED:
-		/* HACK:
+		/* 
+		 * HACK:
 		 *
 		 * wpa_supplicant calls set_wpa_enabled when the driver
 		 * is loaded and unloaded, regardless of if WPA is being
@@ -1727,12 +1732,13 @@ static int r871x_wx_set_auth(struct net_device *dev,
 		 */
 		if (padapter->securitypriv.ndisencryptstatus ==
 		    Ndis802_11Encryption1Enabled) {
-				/* it means init value, or using wep,
-				 * ndisencryptstatus =
-				 *	Ndis802_11Encryption1Enabled,
-				 * then it needn't reset it;
-				 */
-				break;
+			/* 
+			 * it means init value, or using wep,
+			 * ndisencryptstatus =
+			 *	Ndis802_11Encryption1Enabled,
+			 * then it needn't reset it;
+			 */
+			break;
 		}
 
 		if (paramval) {
@@ -1976,9 +1982,9 @@ static int r871x_get_ap_info(struct net_device *dev,
 	if (pdata->length >= 32) {
 		if (copy_from_user(data, pdata->pointer, 32))
 			return -EINVAL;
-                data[32] = 0;
+		data[32] = 0;
 	} else {
-		 return -EINVAL;
+		return -EINVAL;
 	}
 	spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
 	phead = &queue->queue;
@@ -2107,7 +2113,8 @@ static int wpa_set_param(struct net_device *dev, u8 name, u32 value)
 	case IEEE_PARAM_TKIP_COUNTERMEASURES:
 		break;
 	case IEEE_PARAM_DROP_UNENCRYPTED:
-		/* HACK:
+		/* 
+		 * HACK:
 		 *
 		 * wpa_supplicant calls set_wpa_enabled when the driver
 		 * is loaded and unloaded, regardless of if WPA is being
-- 
2.8.2

[toc] | [next] | [standalone]

#1475124 — Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> fixed comment style and space indent report from checkpatch:
> 
> * WARNING: Statements should start on a tabstop
> * WARNING: Block comments use * on subsequent lines
> * WARNING: suspect code indent for conditional statements (16, 32)
> 
> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 15 deletions(-)

This patch adds errors :(

Now if you want to constantly submit new checkpatch cleanups to the
driver, that's a good thing, but really, please use checkpatch on your
patches to ensure you are doing things properly.

I'm dropping it from my patch queue.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1475139 — Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

On Fri, Sep 02, 2016 at 09:04:29PM +0800, Louie Lu wrote:
> 2016-09-02 20:55 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> >> fixed comment style and space indent report from checkpatch:
> >>
> >> * WARNING: Statements should start on a tabstop
> >> * WARNING: Block comments use * on subsequent lines
> >> * WARNING: suspect code indent for conditional statements (16, 32)
> >>
> >> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
> >> ---
> >>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
> >>  1 file changed, 22 insertions(+), 15 deletions(-)
> >
> > This patch adds errors :(
> >
> > Now if you want to constantly submit new checkpatch cleanups to the
> > driver, that's a good thing, but really, please use checkpatch on your
> > patches to ensure you are doing things properly.
> >
> > I'm dropping it from my patch queue.
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> sorry about that I didn't know I add error to this file.
> I'll make sure this won't happen again.
> 
> And if I want to resubmit this patch 3/3, I'll only need to resend this one,
> like [PATCH 3/3 v2] this way?

I've already taken the first 2 so just send it as a single patch.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1475140

2016-09-02 20:55 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
>> fixed comment style and space indent report from checkpatch:
>>
>> * WARNING: Statements should start on a tabstop
>> * WARNING: Block comments use * on subsequent lines
>> * WARNING: suspect code indent for conditional statements (16, 32)
>>
>> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
>> ---
>>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
>>  1 file changed, 22 insertions(+), 15 deletions(-)
>
> This patch adds errors :(
>
> Now if you want to constantly submit new checkpatch cleanups to the
> driver, that's a good thing, but really, please use checkpatch on your
> patches to ensure you are doing things properly.
>
> I'm dropping it from my patch queue.
>
> thanks,
>
> greg k-h

Hi Greg,

sorry about that I didn't know I add error to this file.
I'll make sure this won't happen again.

And if I want to resubmit this patch 3/3, I'll only need to resend this one,
like [PATCH 3/3 v2] this way?

thanks,

Louie Lu

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web