Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475124

Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

Show all headers | View raw

On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> fixed comment style and space indent report from checkpatch:
> 
> * WARNING: Statements should start on a tabstop
> * WARNING: Block comments use * on subsequent lines
> * WARNING: suspect code indent for conditional statements (16, 32)
> 
> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 15 deletions(-)

This patch adds errors :(

Now if you want to constantly submit new checkpatch cleanups to the
driver, that's a good thing, but really, please use checkpatch on your
patches to ensure you are doing things properly.

I'm dropping it from my patch queue.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: rtl8712: fixed comment style and space indent Louie Lu <louie.lu@hopebaytech.com> - 2016-09-02 12:20 +0200
  Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space  indent Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 15:00 +0200
    Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space  indent Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 15:10 +0200
    Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Louie Lu <louie.lu@hopebaytech.com> - 2016-09-02 15:10 +0200

csiph-web