Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474606 > unrolled thread

[PATCH 0/2] constify watchdog_ops structures

Started byJulia Lawall <Julia.Lawall@lip6.fr>
First post2016-09-01 23:20 +0200
Last post2016-09-09 06:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
    [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
      Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Thierry Reding <thierry.reding@gmail.com> - 2016-09-06 11:20 +0200
      Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Guenter Roeck <linux@roeck-us.net> - 2016-09-09 06:30 +0200
    [PATCH 2/2] watchdog: constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
      Re: [PATCH 2/2] watchdog: constify watchdog_ops structures Guenter Roeck <linux@roeck-us.net> - 2016-09-09 06:30 +0200

#1474606 — [PATCH 0/2] constify watchdog_ops structures

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2016-09-01 23:20 +0200
Subject[PATCH 0/2] constify watchdog_ops structures
Message-ID<scHyW-75a-3@gated-at.bofh.it>
Constify watchdog_ops structures.

---

 drivers/watchdog/bcm7038_wdt.c  |    2 +-
 drivers/watchdog/cadence_wdt.c  |    2 +-
 drivers/watchdog/kempld_wdt.c   |    2 +-
 drivers/watchdog/rn5t618_wdt.c  |    2 +-
 drivers/watchdog/softdog.c      |    2 +-
 drivers/watchdog/tegra_wdt.c    |    2 +-
 drivers/watchdog/w83627hf_wdt.c |    2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

[toc] | [next] | [standalone]

#1474626 — [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2016-09-01 23:20 +0200
Subject[PATCH 1/2] watchdog: tegra: constify watchdog_ops structures
Message-ID<scHyX-75a-53@gated-at.bofh.it>
In reply to#1474606
Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure.  This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };

@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct watchdog_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/watchdog/tegra_wdt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
index 9ec5760..2d53c3f 100644
--- a/drivers/watchdog/tegra_wdt.c
+++ b/drivers/watchdog/tegra_wdt.c
@@ -178,7 +178,7 @@ static const struct watchdog_info tegra_wdt_info = {
 	.identity	= "Tegra Watchdog",
 };
 
-static struct watchdog_ops tegra_wdt_ops = {
+static const struct watchdog_ops tegra_wdt_ops = {
 	.owner = THIS_MODULE,
 	.start = tegra_wdt_start,
 	.stop = tegra_wdt_stop,

[toc] | [prev] | [next] | [standalone]

#1477205 — Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures

FromThierry Reding <thierry.reding@gmail.com>
Date2016-09-06 11:20 +0200
SubjectRe: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures
Message-ID<sekHU-8tW-27@gated-at.bofh.it>
In reply to#1474626

[Multipart message — attachments visible in raw view] — view raw

On Thu, Sep 01, 2016 at 07:35:25PM +0200, Julia Lawall wrote:
> Check for watchdog_ops structures that are only stored in the ops field of
> a watchdog_device structure.  This field is declared const, so watchdog_ops
> structures that have this property can be declared as const also.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct watchdog_ops i@p = { ... };
> 
> @ok@
> identifier r.i;
> struct watchdog_device e;
> position p;
> @@
> e.ops = &i@p;
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct watchdog_ops e;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct watchdog_ops i = { ... };
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/watchdog/tegra_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[toc] | [prev] | [next] | [standalone]

#1479645 — Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures

FromGuenter Roeck <linux@roeck-us.net>
Date2016-09-09 06:30 +0200
SubjectRe: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures
Message-ID<sflBU-6IG-13@gated-at.bofh.it>
In reply to#1474626
On 09/01/2016 10:35 AM, Julia Lawall wrote:
> Check for watchdog_ops structures that are only stored in the ops field of
> a watchdog_device structure.  This field is declared const, so watchdog_ops
> structures that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct watchdog_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct watchdog_device e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct watchdog_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct watchdog_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/tegra_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
> index 9ec5760..2d53c3f 100644
> --- a/drivers/watchdog/tegra_wdt.c
> +++ b/drivers/watchdog/tegra_wdt.c
> @@ -178,7 +178,7 @@ static const struct watchdog_info tegra_wdt_info = {
>  	.identity	= "Tegra Watchdog",
>  };
>
> -static struct watchdog_ops tegra_wdt_ops = {
> +static const struct watchdog_ops tegra_wdt_ops = {
>  	.owner = THIS_MODULE,
>  	.start = tegra_wdt_start,
>  	.stop = tegra_wdt_stop,
>
>

[toc] | [prev] | [next] | [standalone]

#1474628 — [PATCH 2/2] watchdog: constify watchdog_ops structures

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2016-09-01 23:20 +0200
Subject[PATCH 2/2] watchdog: constify watchdog_ops structures
Message-ID<scHyX-75a-61@gated-at.bofh.it>
In reply to#1474606
Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure.  This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };

@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct watchdog_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/watchdog/bcm7038_wdt.c  |    2 +-
 drivers/watchdog/cadence_wdt.c  |    2 +-
 drivers/watchdog/kempld_wdt.c   |    2 +-
 drivers/watchdog/rn5t618_wdt.c  |    2 +-
 drivers/watchdog/softdog.c      |    2 +-
 drivers/watchdog/w83627hf_wdt.c |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/watchdog/bcm7038_wdt.c b/drivers/watchdog/bcm7038_wdt.c
index 4245b65..e238df4 100644
--- a/drivers/watchdog/bcm7038_wdt.c
+++ b/drivers/watchdog/bcm7038_wdt.c
@@ -107,7 +107,7 @@ static struct watchdog_info bcm7038_wdt_info = {
 				WDIOF_MAGICCLOSE
 };
 
-static struct watchdog_ops bcm7038_wdt_ops = {
+static const struct watchdog_ops bcm7038_wdt_ops = {
 	.owner		= THIS_MODULE,
 	.start		= bcm7038_wdt_start,
 	.stop		= bcm7038_wdt_stop,
diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
index 4dda902..a4e05e43 100644
--- a/drivers/watchdog/cadence_wdt.c
+++ b/drivers/watchdog/cadence_wdt.c
@@ -269,7 +269,7 @@ static struct watchdog_info cdns_wdt_info = {
 };
 
 /* Watchdog Core Ops */
-static struct watchdog_ops cdns_wdt_ops = {
+static const struct watchdog_ops cdns_wdt_ops = {
 	.owner = THIS_MODULE,
 	.start = cdns_wdt_start,
 	.stop = cdns_wdt_stop,
diff --git a/drivers/watchdog/kempld_wdt.c b/drivers/watchdog/kempld_wdt.c
index 5bf931c..8e302d0 100644
--- a/drivers/watchdog/kempld_wdt.c
+++ b/drivers/watchdog/kempld_wdt.c
@@ -430,7 +430,7 @@ static struct watchdog_info kempld_wdt_info = {
 			WDIOF_PRETIMEOUT
 };
 
-static struct watchdog_ops kempld_wdt_ops = {
+static const struct watchdog_ops kempld_wdt_ops = {
 	.owner		= THIS_MODULE,
 	.start		= kempld_wdt_start,
 	.stop		= kempld_wdt_stop,
diff --git a/drivers/watchdog/rn5t618_wdt.c b/drivers/watchdog/rn5t618_wdt.c
index d1c1227..0805ee2 100644
--- a/drivers/watchdog/rn5t618_wdt.c
+++ b/drivers/watchdog/rn5t618_wdt.c
@@ -136,7 +136,7 @@ static struct watchdog_info rn5t618_wdt_info = {
 	.identity	= DRIVER_NAME,
 };
 
-static struct watchdog_ops rn5t618_wdt_ops = {
+static const struct watchdog_ops rn5t618_wdt_ops = {
 	.owner          = THIS_MODULE,
 	.start          = rn5t618_wdt_start,
 	.stop           = rn5t618_wdt_stop,
diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c
index b067edf..1ae469e 100644
--- a/drivers/watchdog/softdog.c
+++ b/drivers/watchdog/softdog.c
@@ -92,7 +92,7 @@ static struct watchdog_info softdog_info = {
 	.options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE,
 };
 
-static struct watchdog_ops softdog_ops = {
+static const struct watchdog_ops softdog_ops = {
 	.owner = THIS_MODULE,
 	.start = softdog_ping,
 	.stop = softdog_stop,
diff --git a/drivers/watchdog/w83627hf_wdt.c b/drivers/watchdog/w83627hf_wdt.c
index 09e8003..ef2ecaf 100644
--- a/drivers/watchdog/w83627hf_wdt.c
+++ b/drivers/watchdog/w83627hf_wdt.c
@@ -302,7 +302,7 @@ static struct watchdog_info wdt_info = {
 	.identity = "W83627HF Watchdog",
 };
 
-static struct watchdog_ops wdt_ops = {
+static const struct watchdog_ops wdt_ops = {
 	.owner = THIS_MODULE,
 	.start = wdt_start,
 	.stop = wdt_stop,

[toc] | [prev] | [next] | [standalone]

#1479648 — Re: [PATCH 2/2] watchdog: constify watchdog_ops structures

FromGuenter Roeck <linux@roeck-us.net>
Date2016-09-09 06:30 +0200
SubjectRe: [PATCH 2/2] watchdog: constify watchdog_ops structures
Message-ID<sflBU-6IG-23@gated-at.bofh.it>
In reply to#1474628
On 09/01/2016 10:35 AM, Julia Lawall wrote:
> Check for watchdog_ops structures that are only stored in the ops field of
> a watchdog_device structure.  This field is declared const, so watchdog_ops
> structures that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct watchdog_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct watchdog_device e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct watchdog_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct watchdog_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web