Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479645

Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures

Show all headers | View raw

On 09/01/2016 10:35 AM, Julia Lawall wrote:
> Check for watchdog_ops structures that are only stored in the ops field of
> a watchdog_device structure.  This field is declared const, so watchdog_ops
> structures that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct watchdog_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct watchdog_device e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct watchdog_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct watchdog_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/tegra_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
> index 9ec5760..2d53c3f 100644
> --- a/drivers/watchdog/tegra_wdt.c
> +++ b/drivers/watchdog/tegra_wdt.c
> @@ -178,7 +178,7 @@ static const struct watchdog_info tegra_wdt_info = {
>  	.identity	= "Tegra Watchdog",
>  };
>
> -static struct watchdog_ops tegra_wdt_ops = {
> +static const struct watchdog_ops tegra_wdt_ops = {
>  	.owner = THIS_MODULE,
>  	.start = tegra_wdt_start,
>  	.stop = tegra_wdt_stop,
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
  [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
    Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Thierry Reding <thierry.reding@gmail.com> - 2016-09-06 11:20 +0200
    Re: [PATCH 1/2] watchdog: tegra: constify watchdog_ops structures Guenter Roeck <linux@roeck-us.net> - 2016-09-09 06:30 +0200
  [PATCH 2/2] watchdog: constify watchdog_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 23:20 +0200
    Re: [PATCH 2/2] watchdog: constify watchdog_ops structures Guenter Roeck <linux@roeck-us.net> - 2016-09-09 06:30 +0200

csiph-web