Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471709 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-08-29 12:50 +0200 |
| Last post | 2016-09-02 12:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] [SCSI] qla4xxx: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-29 12:50 +0200
Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible Nilesh Javali <nilesh.javali@qlogic.com> - 2016-09-01 13:40 +0200
Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-02 12:10 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-08-29 12:50 +0200 |
| Subject | [PATCH] [SCSI] qla4xxx: mark symbols static where possible |
| Message-ID | <sbsiB-6dl-5@gated-at.bofh.it> |
We get 1 warning when build kernel with W=1:
drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for 'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
index ae87d6c..06ddd13 100644
--- a/drivers/scsi/qla4xxx/ql4_nx.c
+++ b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct scsi_qla_host *ha,
return rval;
}
-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1,
+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1,
uint32_t addr3, uint32_t mask, uint32_t addr,
uint32_t *data_ptr)
{
--
2.7.4
[toc] | [next] | [standalone]
| From | Nilesh Javali <nilesh.javali@qlogic.com> |
|---|---|
| Date | 2016-09-01 13:40 +0200 |
| Message-ID | <scyvE-1dR-21@gated-at.bofh.it> |
| In reply to | #1471709 |
On 29/08/16 4:16 PM, "Baoyou Xie" <baoyou.xie@linaro.org> wrote:
>We get 1 warning when build kernel with W=1:
>drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for
>'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes]
>
>In fact, this function is only used in the file in which it is
>declared and don't need a declaration, but can be made static.
>so this patch marks this function with 'static'.
>
>Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>---
> drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
>index ae87d6c..06ddd13 100644
>--- a/drivers/scsi/qla4xxx/ql4_nx.c
>+++ b/drivers/scsi/qla4xxx/ql4_nx.c
>@@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct
>scsi_qla_host *ha,
> return rval;
> }
>
>-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1,
>+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha,
>uint32_t addr1,
> uint32_t addr3, uint32_t mask, uint32_t addr,
> uint32_t *data_ptr)
> {
>--
>2.7.4
Acked-by: Nilesh Javali <nilesh.javali@qlogic.com>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-09-02 12:10 +0200 |
| Message-ID | <scTA5-6xn-15@gated-at.bofh.it> |
| In reply to | #1471709 |
>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@linaro.org> writes: Baoyou> We get 1 warning when build kernel with W=1: Baoyou> drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous Baoyou> prototype for 'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes] Baoyou> In fact, this function is only used in the file in which it is Baoyou> declared and don't need a declaration, but can be made static. Baoyou> so this patch marks this function with 'static'. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web