Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474342

Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible

Show all headers | View raw

On 29/08/16 4:16 PM, "Baoyou Xie" <baoyou.xie@linaro.org> wrote:

>We get 1 warning when build kernel with W=1:
>drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for
>'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes]
>
>In fact, this function is only used in the file in which it is
>declared and don't need a declaration, but can be made static.
>so this patch marks this function with 'static'.
>
>Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>---
> drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
>index ae87d6c..06ddd13 100644
>--- a/drivers/scsi/qla4xxx/ql4_nx.c
>+++ b/drivers/scsi/qla4xxx/ql4_nx.c
>@@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct
>scsi_qla_host *ha,
> 	return rval;
> }
> 
>-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1,
>+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha,
>uint32_t addr1,
> 				uint32_t addr3, uint32_t mask, uint32_t addr,
> 				uint32_t *data_ptr)
> {
>-- 
>2.7.4


Acked-by: Nilesh Javali <nilesh.javali@qlogic.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [SCSI] qla4xxx: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-29 12:50 +0200
  Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible Nilesh Javali <nilesh.javali@qlogic.com> - 2016-09-01 13:40 +0200
  Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-02 12:10 +0200

csiph-web