Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471632 > unrolled thread
| Started by | Felipe Balbi <balbi@kernel.org> |
|---|---|
| First post | 2016-08-29 10:20 +0200 |
| Last post | 2016-08-29 10:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information Felipe Balbi <balbi@kernel.org> - 2016-08-29 10:20 +0200
Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard <romain.izard.pro@gmail.com> - 2016-08-29 10:30 +0200
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-08-29 10:20 +0200 |
| Subject | Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information |
| Message-ID | <sbpXr-4So-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi,
Romain Izard <romain.izard.pro@gmail.com> writes:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/usb/gadget/configfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> - dev_err(&gi->cdev.gadget->dev, "unbind function"
> - " '%s'/%p\n", f->name, f);
> + dev_info(&gi->cdev.gadget->dev,
seems to me dev_dbg() is a far better alternative. We really don't need
this on everybody's log buffer unless they really _are_ debugging some
possible issues.
--
balbi
[toc] | [next] | [standalone]
| From | Romain Izard <romain.izard.pro@gmail.com> |
|---|---|
| Date | 2016-08-29 10:30 +0200 |
| Message-ID | <sbq78-4Wv-9@gated-at.bofh.it> |
| In reply to | #1471632 |
2016-08-29 10:13 GMT+02:00 Felipe Balbi <balbi@kernel.org>:
>
> Hi,
>
> Romain Izard <romain.izard.pro@gmail.com> writes:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as information, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> drivers/usb/gadget/configfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index 70cf3477f951..11f3a649d9e5 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>> list_move_tail(&f->list, &cfg->func_list);
>> if (f->unbind) {
>> - dev_err(&gi->cdev.gadget->dev, "unbind function"
>> - " '%s'/%p\n", f->name, f);
>> + dev_info(&gi->cdev.gadget->dev,
>
> seems to me dev_dbg() is a far better alternative. We really don't need
> this on everybody's log buffer unless they really _are_ debugging some
> possible issues.
OK, I'll send a v2.
--
Romain Izard
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web