Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information
Date	2016-08-29 10:20 +0200
Message-ID	<sbpXr-4So-7@gated-at.bofh.it> (permalink)
References	<rZdoZ-4i9-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Romain Izard <romain.izard.pro@gmail.com> writes:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
>  drivers/usb/gadget/configfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>  
>  			list_move_tail(&f->list, &cfg->func_list);
>  			if (f->unbind) {
> -				dev_err(&gi->cdev.gadget->dev, "unbind function"
> -						" '%s'/%p\n", f->name, f);
> +				dev_info(&gi->cdev.gadget->dev,

seems to me dev_dbg() is a far better alternative. We really don't need
this on everybody's log buffer unless they really _are_ debugging some
possible issues.

-- 
balbi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information Felipe Balbi <balbi@kernel.org> - 2016-08-29 10:20 +0200
  Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard <romain.izard.pro@gmail.com> - 2016-08-29 10:30 +0200

csiph-web