Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472791 > unrolled thread

[PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Started byMoshe Green <mgmoshes@gmail.com>
First post2016-08-30 21:10 +0200
Last post2016-09-03 22:00 +0200
Articles 7 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
    [PATCH 9/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
    [PATCH 6/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
    Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-01 18:10 +0200
      Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c moshe green <mgmoshes@gmail.com> - 2016-09-02 10:30 +0200
        Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 13:40 +0200
          Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-09-03 22:00 +0200

#1472791 — [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromMoshe Green <mgmoshes@gmail.com>
Date2016-08-30 21:10 +0200
Subject[PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<sbWA1-tT-3@gated-at.bofh.it>
Fix a line length warning found by the checkpatch.pl tool in
ddk750_chip.c.

Signed-off-by: Moshe Green <mgmoshes@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index c1356bb..fb27eb4 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -71,7 +71,7 @@ static void setChipClock(unsigned int frequency)
 		pll.clockType = MXCLK_PLL;
 
 		/*
-		* Call calcPllValue() to fill up the other fields for PLL structure.
+		* Call calcPllValue() to fill the other fields of PLL structure.
 		* Sometime, the chip cannot set up the exact clock required by User.
 		* Return value from calcPllValue() gives the actual possible clock.
 		*/
-- 
2.7.4

[toc] | [next] | [standalone]

#1472795 — [PATCH 9/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromMoshe Green <mgmoshes@gmail.com>
Date2016-08-30 21:10 +0200
Subject[PATCH 9/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<sbWA2-tT-49@gated-at.bofh.it>
In reply to#1472791
Fix a line length warning found by the checkpatch.pl tool in
ddk750_chip.c.

Signed-off-by: Moshe Green <mgmoshes@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 07c2537..0049e5d 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -339,7 +339,9 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll)
 		max_d = 3;
 
 	for (N = 15; N > 1; N--) {
-		/* RN will not exceed maximum long if @request <= 285 MHZ (for 32bit cpu) */
+		/* RN will not exceed maximum long
+		 * if @request <= 285 MHZ (for 32bit cpu)
+		 */
 		RN = N * request;
 		quo = RN / input;
 		rem = RN % input;/* rem always small than 14318181 */
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1472797 — [PATCH 6/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromMoshe Green <mgmoshes@gmail.com>
Date2016-08-30 21:10 +0200
Subject[PATCH 6/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<sbWA2-tT-43@gated-at.bofh.it>
In reply to#1472791
Fix a line length warning found by the checkpatch.pl tool in
ddk750_chip.c.

Signed-off-by: Moshe Green <mgmoshes@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 13f8a36..5e954ea 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -308,7 +308,9 @@ int ddk750_initHw(initchip_param_t *pInitParam)
  */
 unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll)
 {
-	/* as sm750 register definition, N located in 2,15 and M located in 1,255	*/
+	/* as sm750 register definition,
+	 * N located in 2,15 and M located in 1,255
+	 */
 	int N, M, X, d;
 	int mini_diff;
 	unsigned int RN, quo, rem, fl_quo;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1474515 — Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-09-01 18:10 +0200
SubjectRe: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<scCIV-43H-3@gated-at.bofh.it>
In reply to#1472791
On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote:
> Fix a line length warning found by the checkpatch.pl tool in
> ddk750_chip.c.
> 
> Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Lots of the patches in this series have the same exact subject: line,
yet they do different things.  Please fix them up and make them more
obvious, or even better yet, merge them into less patches (one type of
thing per file per patch, not one single change per patch).

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1474936 — Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Frommoshe green <mgmoshes@gmail.com>
Date2016-09-02 10:30 +0200
SubjectRe: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<scS1k-5uk-19@gated-at.bofh.it>
In reply to#1474515
There were (mostly) two kinds of warnings that I've handled, "80
character line length" and block comments structure.
Some of the changes involve handling two separate warnings in a single comment.
Where this occurs, should I break down the change into two steps -
fixing a warning at a time?
Or should I fix both warnings in the same commit - and place the
commit in the most appropriate patch?
thanks

Moshe Green

On 1 September 2016 at 19:04, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote:
>> Fix a line length warning found by the checkpatch.pl tool in
>> ddk750_chip.c.
>>
>> Signed-off-by: Moshe Green <mgmoshes@gmail.com>
>> ---
>>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Lots of the patches in this series have the same exact subject: line,
> yet they do different things.  Please fix them up and make them more
> obvious, or even better yet, merge them into less patches (one type of
> thing per file per patch, not one single change per patch).
>
> thanks,
>
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1475069 — Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-09-02 13:40 +0200
SubjectRe: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<scUZc-7lv-13@gated-at.bofh.it>
In reply to#1474936
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote:
> There were (mostly) two kinds of warnings that I've handled, "80
> character line length" and block comments structure.
> Some of the changes involve handling two separate warnings in a single comment.
> Where this occurs, should I break down the change into two steps -
> fixing a warning at a time?
> Or should I fix both warnings in the same commit - and place the
> commit in the most appropriate patch?

Hm, use your best judgement here, what would you want to be on the
receiving end of if you had to review such a patch series?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1475786 — Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

FromMoshe Green <mgmoshes@gmail.com>
Date2016-09-03 22:00 +0200
SubjectRe: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Message-ID<sdpgC-120-9@gated-at.bofh.it>
In reply to#1475069
On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote:
> > There were (mostly) two kinds of warnings that I've handled, "80
> > character line length" and block comments structure.
> > Some of the changes involve handling two separate warnings in a single comment.
> > Where this occurs, should I break down the change into two steps -
> > fixing a warning at a time?
> > Or should I fix both warnings in the same commit - and place the
> > commit in the most appropriate patch?
> 
> Hm, use your best judgement here, what would you want to be on the
> receiving end of if you had to review such a patch series?
> 
> thanks,
> 
> greg k-h

Will do.

thanks,

Moshe Green

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web