Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

From	Moshe Green <mgmoshes@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Date	2016-09-03 22:00 +0200
Message-ID	<sdpgC-120-9@gated-at.bofh.it> (permalink)
References	<sbWA1-tT-3@gated-at.bofh.it> <scCIV-43H-3@gated-at.bofh.it> <scS1k-5uk-19@gated-at.bofh.it> <scUZc-7lv-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote:
> > There were (mostly) two kinds of warnings that I've handled, "80
> > character line length" and block comments structure.
> > Some of the changes involve handling two separate warnings in a single comment.
> > Where this occurs, should I break down the change into two steps -
> > fixing a warning at a time?
> > Or should I fix both warnings in the same commit - and place the
> > commit in the most appropriate patch?
> 
> Hm, use your best judgement here, what would you want to be on the
> receiving end of if you had to review such a patch series?
> 
> thanks,
> 
> greg k-h

Will do.

thanks,

Moshe Green

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
  [PATCH 9/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
  [PATCH 6/9] staging: sm750fb: fix line length coding style issue in  ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-08-30 21:10 +0200
  Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-01 18:10 +0200
    Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c moshe green <mgmoshes@gmail.com> - 2016-09-02 10:30 +0200
      Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 13:40 +0200
        Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue  in ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-09-03 22:00 +0200

csiph-web