Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471228 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-08-27 19:40 +0200 |
| Last post | 2016-08-27 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] fix:memory:of_memory:add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 19:40 +0200
Re: [PATCH] fix:memory:of_memory:add missing header dependencies Greg KH <gregkh@linuxfoundation.org> - 2016-08-27 20:00 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-08-27 19:40 +0200 |
| Subject | [PATCH] fix:memory:of_memory:add missing header dependencies |
| Message-ID | <saPKi-7pY-19@gated-at.bofh.it> |
We get 2 warnings when biuld kernel with W=1: drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes] drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes] In fact, these functions are declared in drivers/memory/of_memory.h so this patch add missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/memory/of_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c index 9daf94b..568f05e 100644 --- a/drivers/memory/of_memory.c +++ b/drivers/memory/of_memory.c @@ -16,6 +16,7 @@ #include <linux/gfp.h> #include <memory/jedec_ddr.h> #include <linux/export.h> +#include "of_memory.h" /** * of_get_min_tck() - extract min timing values for ddr -- 2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-08-27 20:00 +0200 |
| Message-ID | <saQ3E-7wR-9@gated-at.bofh.it> |
| In reply to | #1471228 |
On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote: > We get 2 warnings when biuld kernel with W=1: Why would you do that? > drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes] > drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes] > > In fact, these functions are declared in drivers/memory/of_memory.h > so this patch add missing header dependencies. Why am I not seeing this warning on a "normal" build? If there's no prototype of a function, that seems odd... What about sparse, does that give you the same error here? thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web