Re: [PATCH] fix:memory:of_memory:add missing header dependencies

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fix:memory:of_memory:add missing header dependencies
Date	2016-08-27 20:00 +0200
Message-ID	<saQ3E-7wR-9@gated-at.bofh.it> (permalink)
References	<saPKi-7pY-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:

Why would you do that?

> drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
> drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in drivers/memory/of_memory.h
> so this patch add missing header dependencies.

Why am I not seeing this warning on a "normal" build?  If there's no
prototype of a function, that seems odd...  What about sparse, does that
give you the same error here?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fix:memory:of_memory:add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 19:40 +0200
  Re: [PATCH] fix:memory:of_memory:add missing header dependencies Greg KH <gregkh@linuxfoundation.org> - 2016-08-27 20:00 +0200

csiph-web