Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470250 > unrolled thread

Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used

Started byWolfram Sang <wsa@the-dreams.de>
First post2016-08-25 18:20 +0200
Last post2016-08-25 19:40 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is  used Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 18:20 +0200
    Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is  used Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 18:30 +0200
      Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is  used Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 19:40 +0200

#1470250 — Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-25 18:20 +0200
SubjectRe: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used
Message-ID<sa5xM-3jP-5@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index 3cb8af635db5..f052c3067791 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -349,7 +349,8 @@ static int pca9541_probe(struct i2c_client *client,
>  	force = 0;
>  	if (pdata)
>  		force = pdata->modes[0].adap_id;
> -	muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data), 0,
> +	muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data),
> +			     I2C_MUX_ARBITRATOR,

Does it make sense to rename the file to i2c-arb-* somewhen then? Just
asking, I'll apply the patch anyhow.

[toc] | [next] | [standalone]


#1470257

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-25 18:30 +0200
Message-ID<sa5Hr-3mY-5@gated-at.bofh.it>
In reply to#1470250

[Multipart message — attachments visible in raw view] — view raw

On Thu, Aug 25, 2016 at 06:22:37PM +0200, Peter Rosin wrote:
> On 2016-08-25 18:19, Wolfram Sang wrote:
> > 
> >> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> index 3cb8af635db5..f052c3067791 100644
> >> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> @@ -349,7 +349,8 @@ static int pca9541_probe(struct i2c_client *client,
> >>  	force = 0;
> >>  	if (pdata)
> >>  		force = pdata->modes[0].adap_id;
> >> -	muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data), 0,
> >> +	muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data),
> >> +			     I2C_MUX_ARBITRATOR,
> > 
> > Does it make sense to rename the file to i2c-arb-* somewhen then? Just
> > asking, I'll apply the patch anyhow.
> 
> There should be a clean branch with /only/ this series that both i2c and
> iio can share, to prevent merge problems. I said I'd make such a branch
> in the i2c-mux repo, but you are of course also welcome to provide that
> branch if you prefer...

No, this is fine. Send me a pull request and I'll merge.

[toc] | [prev] | [next] | [standalone]


#1470298

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-25 19:40 +0200
Message-ID<sa6Nb-41J-9@gated-at.bofh.it>
In reply to#1470257

[Multipart message — attachments visible in raw view] — view raw

> Right, I was waiting for some confirmation if v4.8-rc3 was a good base,
> but I'm running out of patience...

For me, it is perfect.

> Anyway, I'll send the pull request no later that tomorrow morning (CEST).

Thanks!

> I assume I can add your ack?

Rather this:

Reviewed-by: Wolfram Sang <wsa@the-dreams.de>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web