Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558406 > unrolled thread

[PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-13 14:40 +0100
    Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-16 07:50 +0100
      Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 13:40 +0100

#1558406 — [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

The driver is only used in DT platforms so there's no need to
have an i2c_device_id table.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes in v2:
- Add Laxman's Acked-by tag to patch 4/4.
- Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4.

 drivers/mfd/max77686.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 896c1bf85acc..b0e8e13c0049 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
 	return 0;
 }
 
-static const struct i2c_device_id max77686_i2c_id[] = {
-	{ "max77686", TYPE_MAX77686 },
-	{ "max77802", TYPE_MAX77802 },
-	{ }
-};
-MODULE_DEVICE_TABLE(i2c, max77686_i2c_id);
-
 #ifdef CONFIG_PM_SLEEP
 static int max77686_suspend(struct device *dev)
 {
@@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = {
 		   .of_match_table = of_match_ptr(max77686_pmic_dt_match),
 	},
 	.probe_new = max77686_i2c_probe,
-	.id_table = max77686_i2c_id,
 };
 
 module_i2c_driver(max77686_i2c_driver);
-- 
2.7.4

[toc] | [next] | [standalone]

#1559478

Hi,

I think that this patch better to squash with patch3.
After applying the patch3, this driver doesn't use
the max77686_i2c_id table.

On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote:
> The driver is only used in DT platforms so there's no need to
> have an i2c_device_id table.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Changes in v2:
> - Add Laxman's Acked-by tag to patch 4/4.
> - Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4.
> 
>  drivers/mfd/max77686.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 896c1bf85acc..b0e8e13c0049 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
>  	return 0;
>  }
>  
> -static const struct i2c_device_id max77686_i2c_id[] = {
> -	{ "max77686", TYPE_MAX77686 },
> -	{ "max77802", TYPE_MAX77802 },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(i2c, max77686_i2c_id);
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int max77686_suspend(struct device *dev)
>  {
> @@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = {
>  		   .of_match_table = of_match_ptr(max77686_pmic_dt_match),
>  	},
>  	.probe_new = max77686_i2c_probe,
> -	.id_table = max77686_i2c_id,
>  };
>  
>  module_i2c_driver(max77686_i2c_driver);
> 


-- 
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1559689

Hello Chanwoo,

Thanks for the review.

On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> Hi,
> 
> I think that this patch better to squash with patch3.
> After applying the patch3, this driver doesn't use
> the max77686_i2c_id table.
> 

I usually prefer to separate each change in a different patch,
AFAICT moving to use the .probe_new callback and removing the
I2C id table are two different changes.

I can squash if that's the correct approach though, I will let
Lee decide.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web