Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559689

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table
Date 2017-01-16 13:40 +0100
Message-ID <t0eJQ-nt-15@gated-at.bofh.it> (permalink)
References <sZaff-1qE-3@gated-at.bofh.it> <t09h8-4Tq-21@gated-at.bofh.it> <sZaff-1qE-1@gated-at.bofh.it> <t09h8-4Tq-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello Chanwoo,

Thanks for the review.

On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> Hi,
> 
> I think that this patch better to squash with patch3.
> After applying the patch3, this driver doesn't use
> the max77686_i2c_id table.
> 

I usually prefer to separate each change in a different patch,
AFAICT moving to use the .probe_new callback and removing the
I2C id table are two different changes.

I can squash if that's the correct approach though, I will let
Lee decide.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-13 14:40 +0100
  Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-16 07:50 +0100
    Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 13:40 +0100
      Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Lee Jones <lee.jones@linaro.org> - 2017-01-23 12:40 +0100
  Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Lee Jones <lee.jones@linaro.org> - 2017-01-23 12:40 +0100

csiph-web