Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1555926 > unrolled thread

Re: Dell XPS13 does not suspend with Linux 4.10-rc3

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Jan Niehusmann <jan@gondor.com> - 2017-01-10 22:30 +0100
    Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Jan Niehusmann <jan@gondor.com> - 2017-01-10 23:30 +0100
      Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 10:00 +0100
        Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-11 10:40 +0100
          RE: Dell XPS13 does not suspend with Linux 4.10-rc3 "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-01-11 10:50 +0100
            Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 18:20 +0100
              RE: Dell XPS13 does not suspend with Linux 4.10-rc3 "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-01-11 23:20 +0100
          Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 10:50 +0100

#1555926 — Re: Dell XPS13 does not suspend with Linux 4.10-rc3

Hi,

On Tue, Jan 10, 2017 at 03:08:32PM +0100, Paul Menzel wrote:
> Testing Linux 4.10-rc{1,2,3} the Dell XPS13 does not suspend with the
> attached configuration. The screen turns black, but the power button never
> goes dark. The white light stays always on.

Same here.
And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
FW"

Suspending from the console with no_console_suspend shows that the last
message is "e1000e: EEE TX LPI TIMER: 00000000" (which is probably
unrelated).

More interesting is the first message missing, ie. the one after the one
mentioned when using a working kernel: "ACPI : EC: event blocked".

This seems to be related to the bisected commit. Maybe it's not even the
kernel's fault, but the EC just happens to change it's behavior when it
got told about the OS type, before?

Jan

[toc] | [next] | [standalone]

#1555976

On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> FW"

Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.

(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)

--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
        MEI_FIXUP(MEI_UUID_WD, mei_wd),
-       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
 };


I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."

Unless there is a better justification, I think the commit should be
reverted, for now.

Jan

[toc] | [prev] | [next] | [standalone]

#1556294

Dear Linux folks,


On 01/10/17 23:24, Jan Niehusmann wrote:
> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>> FW"
>
> Indeed, just disabling the FIXUP implemented by that commit fixes
> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>
> (For the addressees newly added to cc, it seems like the mentioned
> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -406,3 +406,3 @@ static struct mei_fixup {
>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>  };
>
>
> I don't know what this may break, as the description of 7279b23 just
> says:
> "This workaround was added to support other broken OS and we need to
> follow here."
>
> Unless there is a better justification, I think the commit should be
> reverted, for now.

Somebody else already created the bug 192051 in the Linux Kernel Bug 
Tracker [1].


Kind regards,

Paul


[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
     "[Bug 192051] [bisected] No hibernation/suspend/shutdown after 
commit 7279b238badec09efd0545293e64c21feee97f73"

[toc] | [prev] | [next] | [standalone]

#1556323

On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> On 01/10/17 23:24, Jan Niehusmann wrote:
> > On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> > > And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> > > FW"
> > 
> > Indeed, just disabling the FIXUP implemented by that commit fixes
> > suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> > 
> > (For the addressees newly added to cc, it seems like the mentioned
> > commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> > 
> > --- a/drivers/misc/mei/bus-fixup.c
> > +++ b/drivers/misc/mei/bus-fixup.c
> > @@ -406,3 +406,3 @@ static struct mei_fixup {
> >         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> > -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >  };
> > 
> > 
> > I don't know what this may break, as the description of 7279b23 just
> > says:
> > "This workaround was added to support other broken OS and we need to
> > follow here."
> > 
> > Unless there is a better justification, I think the commit should be
> > reverted, for now.
> 
> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
> [1].

There's a fix for this in my tree to go to Linus for 4.10-rc4.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1556325

> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
> 
> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> > On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> 
> >> On 01/10/17 23:24, Jan Niehusmann wrote:
> >>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> >>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
> >>>> to the FW"
> >>>
> >>> Indeed, just disabling the FIXUP implemented by that commit fixes
> >>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >>>
> >>> (For the addressees newly added to cc, it seems like the mentioned
> >>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >>>
> >>> --- a/drivers/misc/mei/bus-fixup.c
> >>> +++ b/drivers/misc/mei/bus-fixup.c
> >>> @@ -406,3 +406,3 @@ static struct mei_fixup {
> >>>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> >>> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>  };
> >>>
> >>>
> >>> I don't know what this may break, as the description of 7279b23 just
> >>> says:
> >>> "This workaround was added to support other broken OS and we need to
> >>> follow here."
> >>>
> >>> Unless there is a better justification, I think the commit should be
> >>> reverted, for now.
> >>
> >> Somebody else already created the bug 192051 in the Linux Kernel Bug
> >> Tracker [1].
> >
> > There's a fix for this in my tree to go to Linus for 4.10-rc4.
> 
> Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
> (9360) now.
> 
> I would have liked if it mentioned suspend issues, and the known broken
> devices in the commit message. That way, I would have found the commit
> more easily.

Yep,  I should probably add that info about the suspend issue, but looks like we broke the whole gen of older devices so we cannot list all of them :(
Tomas

[toc] | [prev] | [next] | [standalone]

#1556738

On 01/11/17 10:49, Winkler, Tomas wrote:

>> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
>>
>> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
>>> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
>>
>>>> On 01/10/17 23:24, Jan Niehusmann wrote:
>>>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>>>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
>>>>>> to the FW"
>>>>>
>>>>> Indeed, just disabling the FIXUP implemented by that commit fixes
>>>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>>>>>
>>>>> (For the addressees newly added to cc, it seems like the mentioned
>>>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>>>>>
>>>>> --- a/drivers/misc/mei/bus-fixup.c
>>>>> +++ b/drivers/misc/mei/bus-fixup.c
>>>>> @@ -406,3 +406,3 @@ static struct mei_fixup {
>>>>>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
>>>>> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>>>> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>>>>  };
>>>>>
>>>>>
>>>>> I don't know what this may break, as the description of 7279b23 just
>>>>> says:
>>>>> "This workaround was added to support other broken OS and we need to
>>>>> follow here."
>>>>>
>>>>> Unless there is a better justification, I think the commit should be
>>>>> reverted, for now.
>>>>
>>>> Somebody else already created the bug 192051 in the Linux Kernel Bug
>>>> Tracker [1].
>>>
>>> There's a fix for this in my tree to go to Linus for 4.10-rc4.
>>
>> Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
>> (9360) now.

As written elsewhere, the issue on the Dell XPS13 seems to be a 
different issue. (No idea, which message I should have replied to.) I 
have to run, and won’t have access to the machine until Monday, so here 
is as far as I got.

```
$ git bisect log
git bisect start
# good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9
git bisect good 69973b830859bc6529a7a0468ba0d80ee5117826
# good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9
git bisect good 69973b830859bc6529a7a0468ba0d80ee5117826
# bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-rc3
git bisect bad a121103c922847ba5010819a3f250f1f7fc84ab8
# bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag 
'staging-4.10-rc1' of 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f
# good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag 
'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537
# good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag 
'drm-for-v4.10' of git://people.freedesktop.org/~airlied/linux
git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797
```

[…]


Kind regards,

Paul

[toc] | [prev] | [next] | [standalone]

#1556982

> 
> On 01/11/17 10:49, Winkler, Tomas wrote:
> 
> >> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
> >>
> >> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> >>> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> >>
> >>>> On 01/10/17 23:24, Jan Niehusmann wrote:
> >>>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> >>>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
> >>>>>> to the FW"
> >>>>>
> >>>>> Indeed, just disabling the FIXUP implemented by that commit fixes
> >>>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >>>>>
> >>>>> (For the addressees newly added to cc, it seems like the mentioned
> >>>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >>>>>
> >>>>> --- a/drivers/misc/mei/bus-fixup.c
> >>>>> +++ b/drivers/misc/mei/bus-fixup.c
> >>>>> @@ -406,3 +406,3 @@ static struct mei_fixup {
> >>>>>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> >>>>> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>>> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>>>  };
> >>>>>
> >>>>>
> >>>>> I don't know what this may break, as the description of 7279b23
> >>>>> just
> >>>>> says:
> >>>>> "This workaround was added to support other broken OS and we need
> >>>>> to follow here."
> >>>>>
> >>>>> Unless there is a better justification, I think the commit should
> >>>>> be reverted, for now.
> >>>>
> >>>> Somebody else already created the bug 192051 in the Linux Kernel
> >>>> Bug Tracker [1].
> >>>
> >>> There's a fix for this in my tree to go to Linus for 4.10-rc4.
> >>
> >> Yes, Tomas referenced it in the bug report. I test it on the Dell
> >> XPS13
> >> (9360) now.
> 
> As written elsewhere, the issue on the Dell XPS13 seems to be a different issue.
> (No idea, which message I should have replied to.) I have to run, and won't
> have access to the machine until Monday, so here is as far as I got.
> 
> ```
> $ git bisect log
> git bisect start
> # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect
> good 69973b830859bc6529a7a0468ba0d80ee5117826
> # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect
> good 69973b830859bc6529a7a0468ba0d80ee5117826
> # bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-rc3 git bisect
> bad a121103c922847ba5010819a3f250f1f7fc84ab8
> # bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag 'staging-
> 4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
> git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f
> # good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag 'clk-for-
> linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
> git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537
> # good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag 'drm-for-
> v4.10' of git://people.freedesktop.org/~airlied/linux
> git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797
> ```

Can you please hattach your .config as well
Thanks
Tomas

[toc] | [prev] | [next] | [standalone]

#1556346

On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:

>> On 01/10/17 23:24, Jan Niehusmann wrote:
>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>>>> FW"
>>>
>>> Indeed, just disabling the FIXUP implemented by that commit fixes
>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>>>
>>> (For the addressees newly added to cc, it seems like the mentioned
>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>>>
>>> --- a/drivers/misc/mei/bus-fixup.c
>>> +++ b/drivers/misc/mei/bus-fixup.c
>>> @@ -406,3 +406,3 @@ static struct mei_fixup {
>>>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
>>> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>>  };
>>>
>>>
>>> I don't know what this may break, as the description of 7279b23 just
>>> says:
>>> "This workaround was added to support other broken OS and we need to
>>> follow here."
>>>
>>> Unless there is a better justification, I think the commit should be
>>> reverted, for now.
>>
>> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
>> [1].
>
> There's a fix for this in my tree to go to Linus for 4.10-rc4.

Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13 
(9360) now.

I would have liked if it mentioned suspend issues, and the known broken 
devices in the commit message. That way, I would have found the commit 
more easily.


Kind regards,

Paul

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web