Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556294

Re: Dell XPS13 does not suspend with Linux 4.10-rc3

Show all headers | View raw

Dear Linux folks,


On 01/10/17 23:24, Jan Niehusmann wrote:
> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>> FW"
>
> Indeed, just disabling the FIXUP implemented by that commit fixes
> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>
> (For the addressees newly added to cc, it seems like the mentioned
> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -406,3 +406,3 @@ static struct mei_fixup {
>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>  };
>
>
> I don't know what this may break, as the description of 7279b23 just
> says:
> "This workaround was added to support other broken OS and we need to
> follow here."
>
> Unless there is a better justification, I think the commit should be
> reverted, for now.

Somebody else already created the bug 192051 in the Linux Kernel Bug 
Tracker [1].


Kind regards,

Paul


[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
     "[Bug 192051] [bisected] No hibernation/suspend/shutdown after 
commit 7279b238badec09efd0545293e64c21feee97f73"

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Jan Niehusmann <jan@gondor.com> - 2017-01-10 22:30 +0100
  Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Jan Niehusmann <jan@gondor.com> - 2017-01-10 23:30 +0100
    Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 10:00 +0100
      Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-11 10:40 +0100
        RE: Dell XPS13 does not suspend with Linux 4.10-rc3 "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-01-11 10:50 +0100
          Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 18:20 +0100
            RE: Dell XPS13 does not suspend with Linux 4.10-rc3 "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-01-11 23:20 +0100
        Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-11 10:50 +0100

csiph-web