Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553969 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2017-01-09 00:20 +0100 |
| Last post | 2017-01-09 17:50 +0100 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 00:20 +0100
Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Andrew Lunn <andrew@lunn.ch> - 2017-01-09 00:40 +0100
Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Florian Fainelli <f.fainelli@gmail.com> - 2017-01-09 02:20 +0100
Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Randy Dunlap <rdunlap@infradead.org> - 2017-01-09 02:40 +0100
Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 17:40 +0100
Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Randy Dunlap <rdunlap@infradead.org> - 2017-01-09 17:50 +0100
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-01-09 00:20 +0100 |
| Subject | [PATCH net-next] net: dsa: select NET_SWITCHDEV |
| Message-ID | <sXuUN-4CQ-7@gated-at.bofh.it> |
DSA wraps SWITCHDEV, thus select it instead of depending on it. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- net/dsa/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 2ae9bb357523..675acbf1502d 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -6,7 +6,8 @@ config HAVE_NET_DSA config NET_DSA tristate "Distributed Switch Architecture" - depends on HAVE_NET_DSA && NET_SWITCHDEV + depends on HAVE_NET_DSA + select NET_SWITCHDEV select PHYLIB ---help--- Say Y if you want to enable support for the hardware switches supported -- 2.11.0
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-01-09 00:40 +0100 |
| Message-ID | <sXve9-4Jm-3@gated-at.bofh.it> |
| In reply to | #1553969 |
On Sun, Jan 08, 2017 at 06:17:24PM -0500, Vivien Didelot wrote:
> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
[toc] | [prev] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-01-09 02:20 +0100 |
| Message-ID | <sXwMV-5Ni-1@gated-at.bofh.it> |
| In reply to | #1553969 |
On 01/08/2017 03:17 PM, Vivien Didelot wrote: > DSA wraps SWITCHDEV, thus select it instead of depending on it. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
[toc] | [prev] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-01-09 02:40 +0100 |
| Message-ID | <sXx6h-5TA-1@gated-at.bofh.it> |
| In reply to | #1553999 |
On 01/08/17 17:18, Florian Fainelli wrote: > On 01/08/2017 03:17 PM, Vivien Didelot wrote: >> DSA wraps SWITCHDEV, thus select it instead of depending on it. >> >> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > but when CONFIG_INET is not enabled, the patch causes this warning: warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET) -- ~Randy
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-01-09 17:40 +0100 |
| Message-ID | <sXL9g-6vS-33@gated-at.bofh.it> |
| In reply to | #1554004 |
Hi Randy,
Randy Dunlap <rdunlap@infradead.org> writes:
> On 01/08/17 17:18, Florian Fainelli wrote:
>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>
>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>
> but when CONFIG_INET is not enabled, the patch causes this warning:
>
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
Thanks for spotting that! Would that be enough to change this first?
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
index 675acbf1502d..c7263b70e72b 100644
--- a/net/dsa/Kconfig
+++ b/net/dsa/Kconfig
@@ -1,6 +1,6 @@
config HAVE_NET_DSA
def_bool y
- depends on NETDEVICES && !S390
+ depends on INET && NETDEVICES && !S390
# Drivers must select NET_DSA and the appropriate tagging format
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-01-09 17:50 +0100 |
| Message-ID | <sXLiW-6zl-13@gated-at.bofh.it> |
| In reply to | #1554468 |
On 01/09/17 08:32, Vivien Didelot wrote: > Hi Randy, > > Randy Dunlap <rdunlap@infradead.org> writes: > >> On 01/08/17 17:18, Florian Fainelli wrote: >>> On 01/08/2017 03:17 PM, Vivien Didelot wrote: >>>> DSA wraps SWITCHDEV, thus select it instead of depending on it. >>>> >>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> >>> >>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> >>> >> >> but when CONFIG_INET is not enabled, the patch causes this warning: >> >> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET) > > Thanks for spotting that! Would that be enough to change this first? > > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig > index 675acbf1502d..c7263b70e72b 100644 > --- a/net/dsa/Kconfig > +++ b/net/dsa/Kconfig > @@ -1,6 +1,6 @@ > config HAVE_NET_DSA > def_bool y > - depends on NETDEVICES && !S390 > + depends on INET && NETDEVICES && !S390 > > # Drivers must select NET_DSA and the appropriate tagging format Yes, thanks. Tested-by: Randy Dunlap <rdunlap@infradead.org> -- ~Randy
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web