Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1554468

Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

From Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
Date 2017-01-09 17:40 +0100
Message-ID <sXL9g-6vS-33@gated-at.bofh.it> (permalink)
References <sXuUN-4CQ-7@gated-at.bofh.it> <sXwMV-5Ni-1@gated-at.bofh.it> <sXx6h-5TA-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Randy,

Randy Dunlap <rdunlap@infradead.org> writes:

> On 01/08/17 17:18, Florian Fainelli wrote:
>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>
>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> 
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>> 
>
> but when CONFIG_INET is not enabled, the patch causes this warning:
>
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)

Thanks for spotting that! Would that be enough to change this first?

    diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
    index 675acbf1502d..c7263b70e72b 100644
    --- a/net/dsa/Kconfig
    +++ b/net/dsa/Kconfig
    @@ -1,6 +1,6 @@
    config HAVE_NET_DSA
            def_bool y
    -       depends on NETDEVICES && !S390
    +       depends on INET && NETDEVICES && !S390

    # Drivers must select NET_DSA and the appropriate tagging format

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 00:20 +0100
  Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Andrew Lunn <andrew@lunn.ch> - 2017-01-09 00:40 +0100
  Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Florian Fainelli <f.fainelli@gmail.com> - 2017-01-09 02:20 +0100
    Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Randy Dunlap <rdunlap@infradead.org> - 2017-01-09 02:40 +0100
      Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 17:40 +0100
        Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV Randy Dunlap <rdunlap@infradead.org> - 2017-01-09 17:50 +0100

csiph-web