Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1553631 > unrolled thread

[PATCH] Stagging :Comedi :Fixed Camel Case Style issue

Back to article view | Back to linux.kernel

Contents

  [PATCH] Stagging :Comedi :Fixed Camel Case Style issue sumit negi <er20snegi@gmail.com> - 2017-01-07 11:20 +0100
    Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-07 14:10 +0100

#1553631 — [PATCH] Stagging :Comedi :Fixed Camel Case Style issue

Fixed a camel style issue.

Signed-off-by: sumit negi <er20snegi@gmail.com>
---
 drivers/staging/comedi/comedidev.h       | 6 +++---
 drivers/staging/comedi/drivers/dt2815.c  | 2 +-
 drivers/staging/comedi/drivers/ni_670x.c | 2 +-
 drivers/staging/comedi/drivers/pcl726.c  | 8 ++++----
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index dcb6376..1e6c5f3 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
 extern const struct comedi_lrange range_unipolar10;
 extern const struct comedi_lrange range_unipolar5;
 extern const struct comedi_lrange range_unipolar2_5;
-extern const struct comedi_lrange range_0_20mA;
-extern const struct comedi_lrange range_4_20mA;
-extern const struct comedi_lrange range_0_32mA;
+extern const struct comedi_lrange range_0_20ma;
+extern const struct comedi_lrange range_4_20ma;
+extern const struct comedi_lrange range_0_32ma;
 extern const struct comedi_lrange range_unknown;
 
 #define range_digital		range_unipolar5
diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers/staging/comedi/drivers/dt2815.c
index 0be77cc..4d8211a 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -174,7 +174,7 @@ static int dt2815_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->range_table_list = devpriv->range_type_list;
 
 	current_range_type = (it->options[3])
-	    ? &range_4_20mA : &range_0_32mA;
+	    ? &range_4_20ma : &range_0_32ma;
 	voltage_range_type = (it->options[2])
 	    ? &range_bipolar5 : &range_unipolar5;
 	for (i = 0; i < 8; i++) {
diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index 74911db..6b4a8d6 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -216,7 +216,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
 		s->range_table_list = range_table_list;
 		for (i = 0; i < 16; i++) {
 			range_table_list[i] = &range_bipolar10;
-			range_table_list[16 + i] = &range_0_20mA;
+			range_table_list[16 + i] = &range_0_20ma;
 		}
 	} else {
 		s->range_table = &range_bipolar10;
diff --git a/drivers/staging/comedi/drivers/pcl726.c b/drivers/staging/comedi/drivers/pcl726.c
index 256850c..6eb58a0 100644
--- a/drivers/staging/comedi/drivers/pcl726.c
+++ b/drivers/staging/comedi/drivers/pcl726.c
@@ -79,7 +79,7 @@ static const struct comedi_lrange *const rangelist_726[] = {
 	&range_unipolar10,
 	&range_bipolar5,
 	&range_bipolar10,
-	&range_4_20mA,
+	&range_4_20ma,
 	&range_unknown
 };
 
@@ -87,7 +87,7 @@ static const struct comedi_lrange *const rangelist_727[] = {
 	&range_unipolar5,
 	&range_unipolar10,
 	&range_bipolar5,
-	&range_4_20mA
+	&range_4_20ma
 };
 
 static const struct comedi_lrange *const rangelist_728[] = {
@@ -95,8 +95,8 @@ static const struct comedi_lrange *const rangelist_728[] = {
 	&range_unipolar10,
 	&range_bipolar5,
 	&range_bipolar10,
-	&range_4_20mA,
-	&range_0_20mA
+	&range_4_20ma,
+	&range_0_20ma
 };
 
 struct pcl726_board {
-- 
2.9.3

[toc] | [next] | [standalone]

#1553656

On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote:
> Fixed a camel style issue.

Really?  Look at what you changed:

> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;

mA means something, correct?  Why did you change that?

checkpatch is a _hint_, you still always have to use your brain.  Don't
blindly make changes that make no sense, like this one :(

sorry,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web