Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue
Date	2017-01-07 14:10 +0100
Message-ID	<sWYUV-Nx-13@gated-at.bofh.it> (permalink)
References	<sWWgq-7kM-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote:
> Fixed a camel style issue.

Really?  Look at what you changed:

> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;

mA means something, correct?  Why did you change that?

checkpatch is a _hint_, you still always have to use your brain.  Don't
blindly make changes that make no sense, like this one :(

sorry,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Stagging :Comedi :Fixed Camel Case Style issue sumit negi <er20snegi@gmail.com> - 2017-01-07 11:20 +0100
  Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-07 14:10 +0100

csiph-web