Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553096 > unrolled thread
| Started by | Tejun Heo <tj@kernel.org> |
|---|---|
| First post | 2017-01-06 21:50 +0100 |
| Last post | 2017-01-08 23:20 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Tejun Heo <tj@kernel.org> - 2017-01-06 21:50 +0100
Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-07 00:00 +0100
Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Tejun Heo <tj@kernel.org> - 2017-01-08 19:50 +0100
Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-08 23:20 +0100
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2017-01-06 21:50 +0100 |
| Subject | Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. |
| Message-ID | <sWJCx-7a6-1@gated-at.bofh.it> |
On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Then hpriv->base = NULL - 0x20000; Kernel can run into > a NULL-pointer dereference. This error check will avoid > NULL pointer dereference. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied to libata/for-4.10-fixes. Thanks. -- tejun
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-01-07 00:00 +0100 |
| Message-ID | <sWLEm-9g-71@gated-at.bofh.it> |
| In reply to | #1553096 |
On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote: > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote: >> Here, If devm_ioremap will fail. It will return NULL. >> Then hpriv->base = NULL - 0x20000; Kernel can run into >> a NULL-pointer dereference. This error check will avoid >> NULL pointer dereference. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > Applied to libata/for-4.10-fixes. Hold on, why not to convert to devm_ioremap_resource() ? -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2017-01-08 19:50 +0100 |
| Message-ID | <sXqHv-1Gk-1@gated-at.bofh.it> |
| In reply to | #1553445 |
On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote: > On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote: > > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote: > >> Here, If devm_ioremap will fail. It will return NULL. > >> Then hpriv->base = NULL - 0x20000; Kernel can run into > >> a NULL-pointer dereference. This error check will avoid > >> NULL pointer dereference. > >> > >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > > > Applied to libata/for-4.10-fixes. > > Hold on, why not to convert to devm_ioremap_resource() ? Care to send the patch? Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-01-08 23:20 +0100 |
| Message-ID | <sXtYK-426-15@gated-at.bofh.it> |
| In reply to | #1553919 |
On Sun, Jan 8, 2017 at 8:49 PM, Tejun Heo <tj@kernel.org> wrote: > On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote: >> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote: >> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote: >> >> Here, If devm_ioremap will fail. It will return NULL. >> >> Then hpriv->base = NULL - 0x20000; Kernel can run into >> >> a NULL-pointer dereference. This error check will avoid >> >> NULL pointer dereference. >> >> >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> > >> > Applied to libata/for-4.10-fixes. >> >> Hold on, why not to convert to devm_ioremap_resource() ? > > Care to send the patch? Incremental or substitute? -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web