Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553445

Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
Date 2017-01-07 00:00 +0100
Message-ID <sWLEm-9g-71@gated-at.bofh.it> (permalink)
References <sNCTD-7fH-7@gated-at.bofh.it> <sWJCx-7a6-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote:
> On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
>> Here, If devm_ioremap will fail. It will return NULL.
>> Then hpriv->base = NULL - 0x20000; Kernel can run into
>> a NULL-pointer dereference. This error check will avoid
>> NULL pointer dereference.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Applied to libata/for-4.10-fixes.

Hold on, why not to convert to devm_ioremap_resource() ?


-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Tejun Heo <tj@kernel.org> - 2017-01-06 21:50 +0100
  Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-07 00:00 +0100
    Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Tejun Heo <tj@kernel.org> - 2017-01-08 19:50 +0100
      Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-08 23:20 +0100

csiph-web