Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550053 > unrolled thread

[PATCH 0/6] ata: Missing HAS_DMA dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] ata: Missing HAS_DMA dependencies Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-03 19:20 +0100
    [PATCH 1/6] ata: SATA_MV should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-03 19:20 +0100
    [PATCH 3/6] ata: ATA_BMDMA should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-03 19:20 +0100
    [PATCH 2/6] ata: SATA_HIGHBANK should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-03 19:20 +0100
    Re: [PATCH 0/6] ata: Missing HAS_DMA dependencies Tejun Heo <tj@kernel.org> - 2017-01-06 17:40 +0100

#1550053 — [PATCH 0/6] ata: Missing HAS_DMA dependencies

	Hi all,

Bartlomiej's "[PATCH 1/3] ata: allow subsystem to be used on m68k arch"
exposed a few missing dependencies on HAS_DMA. This series allows to
build again "allmodconfig" and "allyesconfig" kernels tailored for
Sun-3, which sets NO_DMA=y.

Geert Uytterhoeven (6):
  ata: SATA_MV should depend on HAS_DMA
  ata: SATA_HIGHBANK should depend on HAS_DMA
  ata: ATA_BMDMA should depend on HAS_DMA
  ata: AHCI and other non-SFF native drivers should depend on HAS_DMA
  libata: Make ata_sg_clean() static again
  libata: Protect DMA core code by #ifdef CONFIG_HAS_DMA

 drivers/ata/Kconfig       |  7 ++++++
 drivers/ata/libata-core.c | 61 +++++++++++++++++++++++++++--------------------
 drivers/ata/libata.h      |  1 -
 3 files changed, 42 insertions(+), 27 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[toc] | [next] | [standalone]

#1550054 — [PATCH 1/6] ata: SATA_MV should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "dma_pool_alloc" [drivers/ata/sata_mv.ko] undefined!
    ERROR: "dmam_pool_create" [drivers/ata/sata_mv.ko] undefined!
    ERROR: "dma_pool_free" [drivers/ata/sata_mv.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ata/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index cbd101933c69322a..7b36b791078a4806 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -353,6 +353,7 @@ config SATA_HIGHBANK
 
 config SATA_MV
 	tristate "Marvell SATA support"
+	depends on HAS_DMA
 	depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \
 		   ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST
 	select GENERIC_PHY
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1550055 — [PATCH 3/6] ata: ATA_BMDMA should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "dmam_alloc_coherent" [drivers/ata/libata.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ata/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 275dbbded6dbe03b..a973aa8aa5513eea 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -289,6 +289,7 @@ config SATA_SX4
 
 config ATA_BMDMA
 	bool "ATA BMDMA support"
+	depends on HAS_DMA
 	default y
 	help
 	  This option adds support for SFF ATA controllers with BMDMA
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1550061 — [PATCH 2/6] ata: SATA_HIGHBANK should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/ata/sata_highbank.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ata/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 7b36b791078a4806..275dbbded6dbe03b 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -344,6 +344,7 @@ config SATA_DWC_VDEBUG
 
 config SATA_HIGHBANK
 	tristate "Calxeda Highbank SATA support"
+	depends on HAS_DMA
 	depends on ARCH_HIGHBANK || COMPILE_TEST
 	help
 	  This option enables support for the Calxeda Highbank SoC's
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1552939

On Tue, Jan 03, 2017 at 07:09:43PM +0100, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> Bartlomiej's "[PATCH 1/3] ata: allow subsystem to be used on m68k arch"
> exposed a few missing dependencies on HAS_DMA. This series allows to
> build again "allmodconfig" and "allyesconfig" kernels tailored for
> Sun-3, which sets NO_DMA=y.

Applied to 1-6 to libata/for-4.11.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web