Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548929 > unrolled thread

Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support David Lin <dtwlin@google.com> - 2017-01-02 00:10 +0100
    Re: [PATCH] jump label: pass kbuild_cflags when checking for asm  goto support Steven Rostedt <rostedt@goodmis.org> - 2017-01-02 20:00 +0100

#1548929 — Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

+Cc: Steven Rostedt <rostedt@goodmis.org>
+Cc: Will Deacon <will.deacon@arm.com>

On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default. This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
>
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
>
> Signed-off-by: David Lin <dtwlin@google.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 694111b..f667daa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -790,7 +790,7 @@ KBUILD_CFLAGS   += $(call cc-option,-Werror=incompatible-pointer-types)
>  KBUILD_ARFLAGS := $(call ar-option,D)
>
>  # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
>         KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>         KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
> --
> 2.10.2
>

[toc] | [next] | [standalone]

#1549361 — Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

On Sun, 1 Jan 2017 15:05:45 -0800
David Lin <dtwlin@google.com> wrote:

> +Cc: Steven Rostedt <rostedt@goodmis.org>
> +Cc: Will Deacon <will.deacon@arm.com>
> 
> On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> > Some versions of ARM GCC compiler such as Android toolchain throws
> > in a '-fpic' flag by default. This causes the gcc-goto check script
> > to fail although some config would have '-fno-pic' flag in the
> > KBUILD_CFLAGS.
> >
> > This patch passes the KBUILD_CFLAGS to the check script so that the
> > script does not rely on the default config from different compilers.
> >
> > Signed-off-by: David Lin <dtwlin@google.com>

Acked-by: Steven Rostedt <rostedt@goodmis.org.

-- Steve

> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 694111b..f667daa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -790,7 +790,7 @@ KBUILD_CFLAGS   += $(call
> > cc-option,-Werror=incompatible-pointer-types) KBUILD_ARFLAGS :=
> > $(call ar-option,D)
> >
> >  # check for 'asm goto'
> > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh
> > $(CC)), y) +ifeq ($(shell $(CONFIG_SHELL)
> > $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
> > KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO KBUILD_AFLAGS +=
> > -DCC_HAVE_ASM_GOTO endif
> > --
> > 2.10.2
> >  

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web